Bugzilla – Attachment 26845 Details for
Bug 12024
Add to list opens the list adding UI in two windows
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12024 - Add to list opens the list adding UI in two windows
PASSED-QA-Bug-12024---Add-to-list-opens-the-list-a.patch (text/plain), 2.23 KB, created by
Katrin Fischer
on 2014-04-06 20:42:40 UTC
(
hide
)
Description:
[PASSED QA] Bug 12024 - Add to list opens the list adding UI in two windows
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-04-06 20:42:40 UTC
Size:
2.23 KB
patch
obsolete
>From 1cffae75fcb36aea8c9d1b7d11b08bb6c6e6c1ab Mon Sep 17 00:00:00 2001 >From: Pasi Kallinen <pasi.kallinen@pttk.fi> >Date: Wed, 2 Apr 2014 14:30:03 +0300 >Subject: [PATCH] [PASSED QA] Bug 12024 - Add to list opens the list adding UI > in two windows > >In Item details, when using the menu toolbar for Add To > List, >the list adding UI opens in a popup window, and also in the original >window. The original window should stay showing the item details page. > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Works fixing problem. No koha-qa errors. > >Test: >1. On staff, go to detail of some biblio, >click add to List, described behavior > >2. With patch applied, origina windows stay on item detail > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Confirmed problem in Chromium/Ubuntu. >Patch passes all tests and QA script, works as described. >--- > koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >index 12a4ad0..ff5d4bb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >@@ -234,11 +234,11 @@ CAN_user_serials_create_subscription ) %] > <button class="btn btn-small dropdown-toggle" data-toggle="dropdown">Add to <span class="caret"></span></button> > <ul class="dropdown-menu"> > <li><a href="#" id="addtocart">Cart</a></li> >- <li><a id="addtoshelf" href="/cgi-bin/koha/virtualshelves/addbybiblionumber.pl?biblionumber=[% biblionumber %]">List</a></li> >+ <li><a href="#" id="addtoshelf">List</a></li> > </ul> > </div> > [% ELSIF ( virtualshelves ) %] >- <div class="btn-group"><a id="addtoshelf" class="btn btn-small" href="/cgi-bin/koha/virtualshelves/addbybiblionumber.pl?biblionumber=[% biblionumber %]"><i class="icon-list"></i> Add to list</a> </div> >+ <div class="btn-group"><a id="addtoshelf" class="btn btn-small"><i class="icon-list"></i> Add to list</a> </div> > [% ELSIF ( intranetbookbag ) %] > <div class="btn-group"><a id="addtocart" class="btn btn-small"><i class="icon-shopping-cart"></i> Add to cart</a> </div> > [% END %] >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12024
:
26756
|
26835
| 26845