Attachment 26853 Details for Bug 11885 – Bug 11885 - Follow-up to address issues raised

[patch] Bug 11885 - Follow-up to address issues raised

Bug-11885---Follow-up-to-address-issues-raised.patch (text/plain), 3.25 KB, created by Mark Tompsett on 2014-04-07 04:42:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2014-04-07 04:42:38 UTC

Size: 3.25 KB

patch

obsolete

>From 538b027b20f8c6992f191490a6365fabf0f5ef13 Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Wed, 2 Apr 2014 20:22:44 -0400
>Subject: [PATCH] Bug 11885 - Follow-up to address issues raised
>
>Jonathan Druart raised the following three issues:
>1/ subtags was bold before patch
>2/ 1 dash existed between tag and tag name
>3/ A space has been added ("606 #1 - Sujet nom commun" becomes "606 # 1 Sujet nom commun", "101 ## - Langue" becomes "101 # # Langue")
>
>This patch addresses them in the following way:
>1/ You will note that @ was not bold on the 0 tab.
> Every other tab were bold. By making the similar template
> into a procedure based on the 0XX tab, bolding was lost.
> This patch bolds all subtags including the @, so that
> the visible change is minimized.
>2/ The dash was programmatically added in at the code stage
> previously. This bug fix splits the the single concatenation
> mess into parts which can be styled. This puts the dash back
> into the template. However, it should be noted that the
> spacing for the 0 tab's tag and tag description will have an
> extra space after the hypen that was lacking before.
>3/ ...... is different than
> ...
> ...
> The later puts that extra space. This patch fixes that.
>
>See comment 1 for the test plan.
>---
> .../prog/en/modules/catalogue/MARCdetail.tt | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
>index 69c1463..7d0ec68 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
>@@ -78,10 +78,9 @@ function Changefwk(FwkList) {
> <div class="tag_title">
> [% tab0X.tag %]
> 		 [% IF ( tab0X.tag_ind ) %]
>-		 [% tab0X.tag_ind.substr(0, 1) %]
>-		 [% tab0X.tag_ind.substr(1, 1) %]
>+		 [% tab0X.tag_ind.substr(0, 1) %][% tab0X.tag_ind.substr(1, 1) %]
> 		 [% END %]
>- [% IF (tab0X.tag_desc) %][% tab0X.tag_desc %][% END %]
>+ [% IF (tab0X.tag_desc) %] - [% tab0X.tag_desc %][% END %]
> </div>
> [% ELSE %]
> <div class="tag">
>@@ -89,7 +88,7 @@ function Changefwk(FwkList) {
> [% FOREACH subfiel IN tab0X.subfield %]
> 
> &nbsp;
>- [% UNLESS ( subfiel.hide_marc ) %][% subfiel.marc_subfield %][% END %]
>+ [% UNLESS ( subfiel.hide_marc ) %][% subfiel.marc_subfield %][% END %]
> [% subfiel.short_desc %]
> [% IF ( subfiel.is_url ) %]<a href="[% subfiel.marc_value %]">[% subfiel.marc_value |html %]</a>[% ELSE %][% subfiel.marc_value |html %][% END %]
> [% IF ( subfiel.link ) %]
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 11885: 25770 | 26462 | 26468 | 26469 | 26773 | 26853 | 26917 | 26918 | 26919 | 26992 | 26993 | 26994 | 26995