Bugzilla – Attachment 2695 Details for
Bug 4305
Amazon book covers do not work with ISBN13
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Prevents exception on certain dodgy input
0001-Bug-4305-prevent-errors-when-handling-invalid-ISBN13.patch (text/plain), 705 bytes, created by
Robin Sheat
on 2010-10-20 06:46:38 UTC
(
hide
)
Description:
Prevents exception on certain dodgy input
Filename:
MIME Type:
Creator:
Robin Sheat
Created:
2010-10-20 06:46:38 UTC
Size:
705 bytes
patch
obsolete
>From d96162404ef487f26aef96fb9a361c67941858fe Mon Sep 17 00:00:00 2001 >From: Robin Sheat <robin@catalyst.net.nz> >Date: Wed, 20 Oct 2010 19:25:24 +1300 >Subject: [PATCH] Bug 4305 - prevent errors when handling invalid ISBN13 values > >--- > C4/Koha.pm | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > >diff --git a/C4/Koha.pm b/C4/Koha.pm >index ab9131a..dc2bcfa 100644 >--- a/C4/Koha.pm >+++ b/C4/Koha.pm >@@ -1330,6 +1330,7 @@ sub _isbn_cleanup ($) { > my $isbn = Business::ISBN->new( shift ); > return undef unless $isbn; > $isbn = $isbn->as_isbn10 if $isbn->type eq 'ISBN13'; >+ return undef unless $isbn; > $isbn = $isbn->as_string; > $isbn =~ s/-//g; > return $isbn; >-- >1.7.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 4305
:
2669
|
2670
| 2695 |
2737