Bugzilla – Attachment 27015 Details for
Bug 6070
On a new order defined from suggestion some fields were missing.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PATCH] Bug 6070: publication place and [collection|series]title not properly saved
Bug-6070-publication-place-and-collectionseriestit.patch (text/plain), 7.46 KB, created by
Fridolin Somers
on 2014-04-11 12:22:44 UTC
(
hide
)
Description:
[PATCH] Bug 6070: publication place and [collection|series]title not properly saved
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2014-04-11 12:22:44 UTC
Size:
7.46 KB
patch
obsolete
>From 87cbc31d23218754c58a6e874b44a9567adbc2ad Mon Sep 17 00:00:00 2001 >From: Paul Poulain <paul.poulain@biblibre.com> >Date: Tue, 16 Apr 2013 22:10:00 +0200 >Subject: [PATCH] Bug 6070: publication place and [collection|series]title not > properly saved > >Before this patch, adding an order from a suggestion with a collection title and publication place resulted in loosing those informations > >This patch fixes the behaviour by > * adding a biblioitems.place to TransformKohaToMarc call in addorder.pl > * adding publication place field in neworderempty template > * sending collectiontlte & place fields to templates > >This patch also: > * does some reindenting in addorder.pl > * fixes some UCFirst coding guidelines errors in opac-suggestions.pl >--- > acqui/addorder.pl | 33 +++++++++++----------- > acqui/neworderempty.pl | 2 ++ > .../prog/en/modules/acqui/neworderempty.tt | 18 +++++++++--- > 3 files changed, 33 insertions(+), 20 deletions(-) > >diff --git a/acqui/addorder.pl b/acqui/addorder.pl >index 1b05f07..6afe9be 100755 >--- a/acqui/addorder.pl >+++ b/acqui/addorder.pl >@@ -241,22 +241,23 @@ if ( $orderinfo->{quantity} ne '0' ) { > my $record = TransformKohaToMarc( > { > "biblio.title" => "$$orderinfo{title}", >- "biblio.author" => $$orderinfo{author} ? $$orderinfo{author} : "", >- "biblio.seriestitle" => $$orderinfo{series} ? $$orderinfo{series} : "", >- "biblioitems.isbn" => $$orderinfo{isbn} ? $$orderinfo{isbn} : "", >- "biblioitems.ean" => $$orderinfo{ean} ? $$orderinfo{ean} : "", >- "biblioitems.publishercode" => $$orderinfo{publishercode} ? $$orderinfo{publishercode} : "", >- "biblioitems.publicationyear" => $$orderinfo{publicationyear} ? $$orderinfo{publicationyear}: "", >- "biblio.copyrightdate" => $$orderinfo{publicationyear} ? $$orderinfo{publicationyear}: "", >- "biblioitems.itemtype" => $$orderinfo{itemtype} ? $$orderinfo{itemtype} : "", >- "biblioitems.editionstatement"=> $$orderinfo{editionstatement} ? $$orderinfo{editionstatement} : "", >- "aqorders.branchcode" => $$orderinfo{branchcode} ? $$orderinfo{branchcode} : "", >- "aqorders.quantity" => $$orderinfo{quantity} ? $$orderinfo{quantity} : "", >- "aqorders.listprice" => $$orderinfo{listprice} ? $$orderinfo{listprice} : "", >- "aqorders.uncertainprice" => $$orderinfo{uncertainprice} ? $$orderinfo{uncertainprice} : "", >- "aqorders.rrp" => $$orderinfo{rrp} ? $$orderinfo{rrp} : "", >- "aqorders.ecost" => $$orderinfo{ecost} ? $$orderinfo{ecost} : "", >- "aqorders.discount" => $$orderinfo{discount} ? $$orderinfo{discount} : "", >+ "biblio.author" => $$orderinfo{author} ? $$orderinfo{author} : "", >+ "biblio.seriestitle" => $$orderinfo{series} ? $$orderinfo{series} : "", >+ "biblioitems.isbn" => $$orderinfo{isbn} ? $$orderinfo{isbn} : "", >+ "biblioitems.ean" => $$orderinfo{ean} ? $$orderinfo{ean} : "", >+ "biblioitems.publishercode" => $$orderinfo{publishercode} ? $$orderinfo{publishercode} : "", >+ "biblioitems.publicationyear" => $$orderinfo{publicationyear} ? $$orderinfo{publicationyear} : "", >+ "biblio.copyrightdate" => $$orderinfo{publicationyear} ? $$orderinfo{publicationyear} : "", >+ "biblioitems.place" => $$orderinfo{place} ? $$orderinfo{place} : "", >+ "biblioitems.itemtype" => $$orderinfo{itemtype} ? $$orderinfo{itemtype} : "", >+ "biblioitems.editionstatement"=> $$orderinfo{editionstatement}? $$orderinfo{editionstatement} : "", >+ "aqorders.branchcode" => $$orderinfo{branchcode} ? $$orderinfo{branchcode} : "", >+ "aqorders.quantity" => $$orderinfo{quantity} ? $$orderinfo{quantity} : "", >+ "aqorders.listprice" => $$orderinfo{listprice} ? $$orderinfo{listprice} : "", >+ "aqorders.uncertainprice" => $$orderinfo{uncertainprice} ? $$orderinfo{uncertainprice} : "", >+ "aqorders.rrp" => $$orderinfo{rrp} ? $$orderinfo{rrp} : "", >+ "aqorders.ecost" => $$orderinfo{ecost} ? $$orderinfo{ecost} : "", >+ "aqorders.discount" => $$orderinfo{discount} ? $$orderinfo{discount} : "", > }); > > # create the record in catalogue, with framework '' >diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl >index 9fdf032..d12b329 100755 >--- a/acqui/neworderempty.pl >+++ b/acqui/neworderempty.pl >@@ -400,6 +400,8 @@ $template->param( > ean => $data->{'ean'}, > seriestitle => $data->{'seriestitle'}, > itemtypeloop => \@itemtypes, >+ collectiontitle => $data->{'collectiontitle'}, >+ place => $data->{'place'}, > quantity => $data->{'quantity'}, > quantityrec => $data->{'quantity'}, > rrp => $data->{'rrp'}, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >index 596aa07..02f1ca2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >@@ -272,6 +272,16 @@ $(document).ready(function() > </li> > <li> > [% IF ( biblionumber ) %] >+ <span class="label">Publication place: </span> >+ <input type="hidden" name="place" id="place" value="[% place %]" />[% place %] >+ [% ELSE %] >+ <label for="place">Publication place: </label> >+ <input type="text" size="10" name="place" id="place" value="[% place %]" /> >+ [% END %] >+ </li> >+ >+ <li> >+ [% IF ( biblionumber ) %] > <span class="label">Publication year: </span> > <input type="hidden" name="publicationyear" id="publicationyear" value="[% publicationyear %]" />[% publicationyear %] > [% ELSE %] >@@ -301,11 +311,11 @@ $(document).ready(function() > [% END %] > <li> > [% IF ( biblionumber ) %] >- <span class="label">Series: </span> >- <input type="hidden" name="series" id="series" value="[% seriestitle %]" />[% seriestitle %] >+ <span class="label">Collection title: </span> >+ <input type="hidden" name="series" id="series" value="[% collectiontitle %]" />[% collectiontitle %] > [% ELSE %] >- <label for="series">Series: </label> >- <input type="text" size="50" name="series" id="series" value="[% seriestitle %]" /> >+ <label for="series">Collection title: </label> >+ <input type="text" size="50" name="series" id="series" value="[% collectiontitle %]" /> > [% END %] > </li> > [% UNLESS ( biblionumber ) %] >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6070
:
3707
|
3830
|
4221
|
4222
|
4239
|
4796
|
17493
| 27015