Attachment 27222 Details for Bug 10500 – Bug 10500 [QA Followup] - Add checks for empty isbn

[patch] Bug 10500 [QA Followup] - Add checks for empty isbn

Bug-10500-QA-Followup---Add-checks-for-empty-isbn.patch (text/plain), 1.05 KB, created by Kyle M Hall (khall) on 2014-04-16 15:05:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2014-04-16 15:05:12 UTC

Size: 1.05 KB

patch

obsolete

>From 529b0a47ae46c73603905a400e742477a5859bd5 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 16 Apr 2014 11:03:54 -0400
>Subject: [PATCH] Bug 10500 [QA Followup] - Add checks for empty isbn
>
>---
> C4/Koha.pm |    6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
>diff --git a/C4/Koha.pm b/C4/Koha.pm
>index 3d4672d..2479b9d 100644
>--- a/C4/Koha.pm
>+++ b/C4/Koha.pm
>@@ -1484,7 +1484,7 @@ sub _isbn_cleanup {
>             format        => 'ISBN-10',
>             strip_hyphens => 1,
>         }
>-    );
>+    ) if $isbn;
> }
> 
> =head2 NormalizedISBN
>@@ -1511,6 +1511,8 @@ sub NormalizeISBN {
>     my $strip_hyphens = $params->{strip_hyphens};
>     my $format        = $params->{format};
> 
>+    return unless $string;
>+
>     my $isbn = Business::ISBN->new($string);
> 
>     if ( $isbn && $isbn->error != Business::ISBN::BAD_ISBN ) {
>@@ -1548,6 +1550,8 @@ sub NormalizeISBN {
> sub GetVariationsOfISBN {
>     my ($isbn) = @_;
> 
>+    return unless $isbn;
>+
>     my @isbns;
> 
>     push( @isbns, NormalizeISBN({ isbn => $isbn }) );
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 10500: 19172 | 19174 | 20732 | 20744 | 21072 | 21257 | 21258 | 22840 | 22841 | 22910 | 22911 | 22918 | 22919 | 27220 | 27221 | 27222 | 27387 | 27388 | 27389