Attachment 27254 Details for Bug 10904 – [PASSED QA] Bug 10904 - would like to limit patron update request management by branch

[patch] [PASSED QA] Bug 10904 - would like to limit patron update request management by branch

PASSED-QA-Bug-10904---would-like-to-limit-patron-u.patch (text/plain), 4.15 KB, created by Katrin Fischer on 2014-04-17 14:40:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-04-17 14:40:40 UTC

Size: 4.15 KB

patch

obsolete

>From e82062143753dba863b2a896fc6a3d43882f9810 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 10 Oct 2013 10:46:17 -0400
>Subject: [PATCH] [PASSED QA] Bug 10904 - would like to limit patron update
> request management by branch
>
>By not limiting the patron modification lists by branch, it can quickly
>become overwhelming for a librarian. This patch makes the following
>modifications:
>
>* Only superlibrians will see the full list of borrowers with pending
>  modifications.
>* Adds the patron cardnumber after the patrons name on the modification
>  list.
>* Adds a link to the patron's record from the modification list.
>
>Test Plan:
>1) Apply this patch
>2) Set up some pending modifications for two branches
>3) Log in to the staff intranet as one of those branches
>4) You should note the number of pending modifications counts
>   only your logged in branch's patrons
>5) Click the link, you should only see your logged in branches
>   patrons in the pending modifications list.
>6) You should note the cardnumber is displayed next to the patron name
>7) You should note the "View record" link below each patron's name
>
>Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Comments on last patch.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt | 3 ++-
> mainpage.pl                                                       | 8 +++-----
> members/members-update.pl                                         | 7 +++----
> 3 files changed, 8 insertions(+), 10 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt
>index 4854e39..40a4037 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt
>@@ -75,8 +75,9 @@
>                     <div id="pending_updates">
>                             [% FOREACH pm IN PendingModifications %]
>                                 [% SET borrowernumber = pm.borrowernumber %]
>-                                <h3><a href="#panel_modify_[% pm.borrowernumber %]">[% borrowers.$borrowernumber.surname %], [% borrowers.$borrowernumber.firstname %]</a></h3>
>+                                <h3><a href="#panel_modify_[% pm.borrowernumber %]">[% borrowers.$borrowernumber.surname %], [% borrowers.$borrowernumber.firstname %] ([% borrowers.$borrowernumber.cardnumber %])</a></h3>
>                                 <div id="panel_modify_[% pm.borrowernumber %]">
>+                                    <a target="_blank" href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">View record</a>
>                                     <div style="background-color:#E6F0F2;padding:.5em;margin:.3em 0;">
>                                         <input type="radio" id="approve_modify_[% pm.borrowernumber %]" name="modify_[% pm.borrowernumber %]" value="approve" />
>                                         <label for="approve_modify_[% pm.borrowernumber %]">Approve</label>
>diff --git a/mainpage.pl b/mainpage.pl
>index a0de153..ba5b4c6 100755
>--- a/mainpage.pl
>+++ b/mainpage.pl
>@@ -54,11 +54,9 @@ $template->param(
>     koha_news_count => $koha_news_count
> );
> 
>-my $branch =
>-  C4::Context->preference("IndependentBranches")
>-  && !$flags->{'superlibrarian'}
>-  ? C4::Context->userenv()->{'branch'}
>-  : undef;
>+my $branch = $flags->{'superlibrarian'}
>+  ? undef
>+  : C4::Context->userenv()->{'branch'};
> 
> my $pendingcomments    = numberofreviews(0);
> my $pendingtags        = get_count_by_tag_status(0);
>diff --git a/members/members-update.pl b/members/members-update.pl
>index 0b39552..c8526ab 100755
>--- a/members/members-update.pl
>+++ b/members/members-update.pl
>@@ -42,10 +42,9 @@ my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user(
> );
> 
> my $branch =
>-  C4::Context->preference("IndependentBranches")
>-  && !$flags->{'superlibrarian'}
>-  ? C4::Context->userenv()->{'branch'}
>-  : undef;
>+  $flags->{'superlibrarian'}
>+  ? undef
>+  : C4::Context->userenv()->{'branch'};
> 
> my $pending_modifications =
>   Koha::Borrower::Modifications->GetPendingModifications($branch);
>-- 
>1.8.3.2

Actions: View | Diff | Splinter Review

Attachments on bug 10904: 21950 | 22494 | 23103 | 23104 | 25467 | 25468 | 27253 | 27254 | 27255 | 27256 | 36959 | 36960 | 36961 | 42599 | 42600 | 42601