Bugzilla – Attachment 27284 Details for
Bug 12080
Superserials permission appears to be broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12080 [QA Followup] - Bookseller.t fails
Bug-12080-QA-Followup---Booksellert-fails.patch (text/plain), 1.70 KB, created by
Kyle M Hall (khall)
on 2014-04-18 12:28:12 UTC
(
hide
)
Description:
Bug 12080 [QA Followup] - Bookseller.t fails
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-04-18 12:28:12 UTC
Size:
1.70 KB
patch
obsolete
>From 642adef68baef0f8626117287dd1b59613176f35 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 18 Apr 2014 08:27:35 -0400 >Subject: [PATCH] Bug 12080 [QA Followup] - Bookseller.t fails > >--- > C4/Serials.pm | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/C4/Serials.pm b/C4/Serials.pm >index 64fcf38..4ac1fae 100644 >--- a/C4/Serials.pm >+++ b/C4/Serials.pm >@@ -744,7 +744,7 @@ sub SearchSubscriptions { > !C4::Context->IsSuperLibrarian() && > !C4::Auth::haspermission( $userid, {serials => 'superserials'}); > } >- my $user_branch = C4::Context->userenv->{'branch'}; >+ my $user_branch = C4::Context->userenve ? C4::Context->userenv->{'branch'} : q{}; > for my $subscription ( @$results ) { > $subscription->{cannotedit} = not can_edit_subscription( $subscription ); > $subscription->{cannotdisplay} = >@@ -1540,14 +1540,14 @@ sub NewSubscription { > my $pattern = C4::Serials::Numberpattern::GetSubscriptionNumberpattern($subscription->{numberpattern}); > > # calculate issue number >- my $serialseq = GetSeq($subscription, $pattern); >+ my $serialseq = GetSeq($subscription, $pattern) || q{}; > $query = qq| > INSERT INTO serial > (serialseq,subscriptionid,biblionumber,status, planneddate, publisheddate) > VALUES (?,?,?,?,?,?) > |; > $sth = $dbh->prepare($query); >- $sth->execute( "$serialseq", $subscriptionid, $biblionumber, 1, $firstacquidate, $firstacquidate ); >+ $sth->execute( $serialseq, $subscriptionid, $biblionumber, 1, $firstacquidate, $firstacquidate ); > > logaction( "SERIAL", "ADD", $subscriptionid, "" ) if C4::Context->preference("SubscriptionLog"); > >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12080
:
27115
|
27135
|
27218
|
27219
|
27279
|
27284
|
27286
|
27287