Attachment 27292 Details for Bug 10869 – [PATCH 3/3] Bug 10869: Followup : update the receipt page (parcel.tt)

[patch] [PATCH 3/3] Bug 10869: Followup : update the receipt page (parcel.tt)

0003-Followup-update-the-receipt-page-parcel.tt.patch (text/plain), 3.66 KB, created by Mathieu Saby on 2014-04-18 16:19:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mathieu Saby

Created: 2014-04-18 16:19:40 UTC

Size: 3.66 KB

patch

obsolete

>From c78ce1ab0f526c74fc82a9030ad16d31c62cfb30 Mon Sep 17 00:00:00 2001
>From: Mathieu Saby <mathsabypro@gmail.com>
>Date: Thu, 17 Apr 2014 20:28:15 +0200
>Subject: [PATCH 3/3] Bug 10869: Followup : update the receipt page (parcel.tt)
>Content-Type: text/plain; charset="utf-8"
>
>(Fixed after test by Lyon3 : a bad name was used for a variable.
>Now "Deleted record..." should NOT be displayed if the record has not been deleted)
>
>In main patch, I forgot to made some changes in the parcel.tt page
>This patch fixes that bu giving the librarian the ability to cancel an order in receipt page if the record is deleted.
>It also displays the message "Deleted bibliographic record, can't find title" in Summary
>
>Note that this behavior will be improved by bug 10758
>
>To test :
>- create a basket and an order
>- delete the record used by that order
>- go on receipt page
>- in the line matching this order, you should see instead of the title "Deleted bibliographic record, can't find title"
>- click on "Delete order" : you should be able to delete the order
>- go to the basket, to check the order was properly cancelled
>- in receipt page, try to delete an other order (always linked to a record), to be sure there is no regression
>
>---
> .../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
>index b537148..8e4a984 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
>@@ -265,7 +265,11 @@
> </td>
> <td class="orderfilterclass"><a href="neworderempty.pl?ordernumber=[% loop_order.ordernumber %]&amp;booksellerid=[% loop_order.booksellerid %]">[% loop_order.ordernumber %]</a></td>
> <td class="summaryfilterclass">
>- <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% loop_order.biblionumber %]">[% loop_order.title |html %]</a>
>+ [% IF (loop_order.biblionumber) %]
>+ <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% loop_order.biblionumber %]">[% loop_order.title |html %]</a>
>+ [% ELSE %]
>+ Deleted bibliographic record, can't find title 
>+ [% END %]
> [% IF ( loop_order.author ) %] by [% loop_order.author %][% END %]
> [% IF ( loop_order.isbn ) %] &ndash; [% loop_order.isbn %][% END %]
> [% IF ( loop_order.publishercode ) %] Publisher :[% loop_order.publishercode %][% END %]
>@@ -292,6 +296,9 @@
> <a href="#" onclick="transfer_order_popup([% loop_order.ordernumber %]); return false;">Transfer</a>
> 				</td>
> 				<td>
>+ [% UNLESS (books_loo.biblionumber) %]
>+ <a href="javascript:confirm_delete_item([% loop_order.ordernumber %], [% loop_order.basketno %])" class="button">Delete order</a> 
>+ [% ELSE %]
> [% IF ( loop_order.left_holds_on_order ) %]
> Can't delete order 
> [% ELSE %]
>@@ -314,6 +321,7 @@
> [% IF ( loop_order.left_holds ) %]
> [% loop_order.holds %] hold(s) left
> [% END %]
>+ [% END %]
> </td>
> </tr>
> [% END %]
>-- 
>1.7.9.5
>

Actions: View | Diff | Splinter Review

Attachments on bug 10869: 20970 | 21106 | 21294 | 21295 | 21480 | 22104 | 22299 | 22300 | 22342 | 22676 | 23839 | 24743 | 24744 | 24992 | 25000 | 25001 | 25002 | 25003 | 26692 | 26693 | 27270 | 27292 | 28516 | 29668 | 78862 | 78863 | 78864