Bugzilla – Attachment 27305 Details for
Bug 9416
We should have 2 kinds of notes for each order line
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
0002-PASSED-QA-Bug-9416-Fix-Acquisition.t-UT.patch
0002-PASSED-QA-Bug-9416-Fix-Acquisition.t-UT.patch (text/plain), 3.26 KB, created by
Katrin Fischer
on 2014-04-19 10:21:33 UTC
(
hide
)
Description:
0002-PASSED-QA-Bug-9416-Fix-Acquisition.t-UT.patch
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-04-19 10:21:33 UTC
Size:
3.26 KB
patch
obsolete
>From df159f7a1918728e0905b91615ffd3744496435b Mon Sep 17 00:00:00 2001 >From: Mathieu Saby <mathsabypro@gmail.com> >Date: Sat, 19 Apr 2014 10:22:10 +0200 >Subject: [PATCH 2/3] [PASSED QA] Bug 9416 : Fix Acquisition.t UT > >This patch fixes UT, to take into account the new fields order_internalnote and order_vendornote >Note that "notes" field is still returned as well by some Acquisition subs (those which return all the fields of biblio and biblioitems table) > >Test plan : >run prove t/db_dependant/Acquisition.t > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >--- > t/db_dependent/Acquisition.t | 23 ++++++++++++++++------- > 1 file changed, 16 insertions(+), 7 deletions(-) > >diff --git a/t/db_dependent/Acquisition.t b/t/db_dependent/Acquisition.t >index f2ee820..2730f37 100755 >--- a/t/db_dependent/Acquisition.t >+++ b/t/db_dependent/Acquisition.t >@@ -194,7 +194,8 @@ my @order_content = ( > biblionumber => $biblionumber1, > budget_id => $budget->{budget_id}, > uncertainprice => 0, >- notes => "some notes", >+ order_internalnote => "internal note", >+ order_vendornote => "vendor note" > }, > num => { > quantity => 24, >@@ -219,7 +220,8 @@ my @order_content = ( > biblionumber => $biblionumber2, > budget_id => $budget->{budget_id}, > uncertainprice => 0, >- notes => "ordernotes" >+ order_internalnote => "internal note", >+ order_vendornote => "vendor note" > }, > num => { > quantity => 4, >@@ -237,7 +239,8 @@ my @order_content = ( > basketno => $basketno, > biblionumber => $biblionumber3, > budget_id => $budget->{budget_id}, >- notes => "ordernotes" >+ order_internalnote => "internal note", >+ order_vendornote => "vendor note" > }, > num => { > quantity => 4, >@@ -256,7 +259,8 @@ my @order_content = ( > basketno => $basketno, > biblionumber => $biblionumber4, > budget_id => $budget->{budget_id}, >- notes => "ordernotes" >+ order_internalnote => "internal note", >+ order_vendornote => "vendor note" > }, > num => { > quantity => 1, >@@ -345,6 +349,8 @@ ok( > # > > my @expectedfields = qw( >+ order_internalnote >+ order_vendornote > ordernumber > biblionumber > entrydate >@@ -359,7 +365,6 @@ my @expectedfields = qw( > quantityreceived > cancelledby > datecancellationprinted >- notes > supplierreference > purchaseordernumber > basketno >@@ -427,6 +432,9 @@ is( join( " ", @$test_different_fields ), > # > > my @base_expectedfields = qw( >+ order_internalnote >+ order_vendornote >+ notes > ordernumber > ecost > uncertainprice >@@ -468,7 +476,6 @@ my @base_expectedfields = qw( > subscriptionid > editionresponsibility > sort2 >- notes > volumedate > budget_id > illus >@@ -584,6 +591,9 @@ ok( > # > > @expectedfields = qw ( >+ order_internalnote >+ order_vendornote >+ notes > basketgroupid > basketgroupname > firstname >@@ -635,7 +645,6 @@ ok( > subscriptionid > frameworkcode > sort2 >- notes > datecancellationprinted > budget_id > authorisedby >-- >1.8.3.2 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9416
:
21293
|
21964
|
23798
|
25329
|
25335
|
27231
|
27274
|
27299
|
27300
|
27301
|
27302
|
27304
| 27305 |
27306