Attachment 27334 Details for Bug 12114 – Bug 12114: Fix encoding problem with reports JSON web service (staff)

[patch] Bug 12114: Fix encoding problem with reports JSON web service (staff)

Bug-12114-Fix-encoding-problem-with-reports-JSON-w.patch (text/plain), 1.23 KB, created by Katrin Fischer on 2014-04-20 22:12:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-04-20 22:12:55 UTC

Size: 1.23 KB

patch

obsolete

>From d812e6e57f21d5c2c979233779bf40bce463efd2 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <Katrin.Fischer.83@web.de>
>Date: Mon, 21 Apr 2014 00:07:31 +0200
>Subject: [PATCH] Bug 12114: Fix encoding problem with reports JSON web service
> (staff)
>
>Repeat tests from first patch, but this time, access the report
>with your staff client base URL.
>
><Staff BaseURL>/cgi-bin/koha/svc/report?id=<reportid>
>
>Based on paste from Galen Charlton.
>
>http://bugs.koha-community.org/show_bug.cgi?id=9915
>---
> svc/report | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/svc/report b/svc/report
>index 0cff7dc..839a91b 100755
>--- a/svc/report
>+++ b/svc/report
>@@ -22,7 +22,7 @@ use Modern::Perl;
> 
> use C4::Auth;
> use C4::Reports::Guided;
>-use JSON;
>+use JSON::XS;
> use CGI;
> 
> use Koha::Cache;
>@@ -66,14 +66,14 @@ unless ($json_text) {
>         else {
>             $lines = $sth->fetchall_arrayref;
>         }
>-        $json_text = to_json($lines);
>+        $json_text = encode_json($lines);
> 
>         if ($cache_active) {
>             $cache->set_in_cache( $cache_key, $json_text, $report_rec->{cache_expiry} );
>         }
>     }
>     else {
>-        $json_text = to_json($errors);
>+        $json_text = encode_json($errors);
>     }
> }
> 
>-- 
>1.8.3.2

Actions: View | Diff | Splinter Review

Attachments on bug 12114: 27333 | 27334 | 27360 | 27361 | 27619 | 27620 | 27621