Bugzilla – Attachment 27344 Details for
Bug 11518
Add new method to Koha::Schema::Result::Item that will always return the correct itemtype
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11518 [QA Followup] - Make unit tests pass
Bug-11518-QA-Followup---Make-unit-tests-pass.patch (text/plain), 1.42 KB, created by
Kyle M Hall (khall)
on 2014-04-21 12:22:39 UTC
(
hide
)
Description:
Bug 11518 [QA Followup] - Make unit tests pass
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-04-21 12:22:39 UTC
Size:
1.42 KB
patch
obsolete
>From ea34946041a34d2cfea72172e5b04b419dfdf4c1 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 21 Apr 2014 08:20:28 -0400 >Subject: [PATCH] Bug 11518 [QA Followup] - Make unit tests pass > >--- > t/db_dependent/Items.t | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t >index af7b252..6867f83 100755 >--- a/t/db_dependent/Items.t >+++ b/t/db_dependent/Items.t >@@ -22,7 +22,7 @@ use MARC::Record; > use C4::Biblio; > use Koha::Database; > >-use Test::More tests => 3; >+use Test::More tests => 4; > > BEGIN { > use_ok('C4::Items'); >@@ -169,10 +169,10 @@ subtest q{Test Koha::Database->schema()->resultset('Item')->itemtype()} => sub { > my $biblioitem = $biblio->biblioitem(); > my ( $item ) = $biblioitem->items(); > >- C4::Context->set_preference( 'item-level_itypes', 0 ); >+ $schema->resultset('Systempreference')->update_or_create({ variable => 'item-level_itypes', value => 0 }); > ok( $item->effective_itemtype() eq 'BIB_LEVEL', '$item->itemtype() returns biblioitem.itemtype when item-level_itypes is disabled' ); > >- C4::Context->set_preference( 'item-level_itypes', 1 ); >+ $schema->resultset('Systempreference')->update_or_create({ variable => 'item-level_itypes', value => 1 }); > ok( $item->effective_itemtype() eq 'ITEM_LEVEL', '$item->itemtype() returns items.itype when item-level_itypes is disabled' ); > > >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11518
:
24121
|
24143
|
25448
|
25510
|
26983
|
26985
|
26987
|
27343
|
27344
|
27345
|
27346
|
27347
|
27348
|
29544
|
31240
|
31241
|
31242