Attachment 27376 Details for Bug 10807 – [PASSED QA] Bug 10807: The new field search_history.type should be a varchar(16)

[patch] [PASSED QA] Bug 10807: The new field search_history.type should be a varchar(16)

PASSED-QA-Bug-10807-The-new-field-searchhistorytyp.patch (text/plain), 2.11 KB, created by Katrin Fischer on 2014-04-21 20:16:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-04-21 20:16:38 UTC

Size: 2.11 KB

patch

obsolete

>From 65d047989932c2c941becdcb505be8b8bbaa8f0c Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Tue, 24 Sep 2013 11:13:32 +0200
>Subject: [PATCH] [PASSED QA] Bug 10807: The new field search_history.type
> should be a varchar(16)
>
>varchar(255) is too wide for "biblio" and "authority" values.
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>---
> installer/data/mysql/kohastructure.sql | 2 +-
> installer/data/mysql/updatedatabase.pl | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index 7efeb44..f3d155f 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -1904,7 +1904,7 @@ CREATE TABLE IF NOT EXISTS `search_history` ( -- patron's opac search history
>   `sessionid` varchar(32) NOT NULL, -- a system generated session id
>   `query_desc` varchar(255) NOT NULL, -- the search that was performed
>   `query_cgi` text NOT NULL, -- the string to append to the search url to rerun the search
>-  `type` varchar(255) NOT NULL DEFAULT 'biblio', -- search type, must be 'biblio' or 'authority'
>+  `type` varchar(16) NOT NULL DEFAULT 'biblio', -- search type, must be 'biblio' or 'authority'
>   `total` int(11) NOT NULL, -- the total of results found
>   `time` timestamp NOT NULL default CURRENT_TIMESTAMP, -- the date and time the search was run
>   KEY `userid` (`userid`),
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index c1b750b..064e4f8 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -8206,7 +8206,7 @@ if ( CheckVersion($DBversion) ) {
> $DBversion = "3.15.00.XXX";
> if ( CheckVersion($DBversion) ) {
>     $dbh->do(q|
>-        ALTER TABLE search_history ADD COLUMN type VARCHAR(255) NOT NULL DEFAULT 'biblio' AFTER query_cgi
>+        ALTER TABLE search_history ADD COLUMN type VARCHAR(16) NOT NULL DEFAULT 'biblio' AFTER query_cgi
>     |);
>     print "Upgrade to $DBversion done (Bug 10807 - Add db field search_history.type)\n";
>     SetVersion($DBversion);
>-- 
>1.8.3.2

Actions: View | Diff | Splinter Review

Attachments on bug 10807: 20734 | 20764 | 20951 | 20952 | 20988 | 20989 | 20990 | 21070 | 21362 | 21363 | 21403 | 22560 | 22561 | 22562 | 22563 | 22564 | 22565 | 23676 | 23677 | 23678 | 23679 | 23680 | 23681 | 23682 | 23712 | 24221 | 24222 | 24223 | 24224 | 24225 | 24226 | 27372 | 27373 | 27374 | 27375 | 27376 | 27377 | 27378