Bugzilla – Attachment 27389 Details for
Bug 10500
Improve isbn matching when importing records
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10500 [QA Followup] - Add checks for empty isbn
PASSED-QA-Bug-10500-QA-Followup---Add-checks-for-e.patch (text/plain), 1.12 KB, created by
Martin Renvoize (ashimema)
on 2014-04-22 10:29:38 UTC
(
hide
)
Description:
[PASSED QA] Bug 10500 [QA Followup] - Add checks for empty isbn
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2014-04-22 10:29:38 UTC
Size:
1.12 KB
patch
obsolete
>From fce797b197d0c08d4d069bb83279ac27221edefc Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 16 Apr 2014 11:03:54 -0400 >Subject: [PATCH] [PASSED QA] Bug 10500 [QA Followup] - Add checks for empty > isbn > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Koha.pm | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/C4/Koha.pm b/C4/Koha.pm >index 3d4672d..2479b9d 100644 >--- a/C4/Koha.pm >+++ b/C4/Koha.pm >@@ -1484,7 +1484,7 @@ sub _isbn_cleanup { > format => 'ISBN-10', > strip_hyphens => 1, > } >- ); >+ ) if $isbn; > } > > =head2 NormalizedISBN >@@ -1511,6 +1511,8 @@ sub NormalizeISBN { > my $strip_hyphens = $params->{strip_hyphens}; > my $format = $params->{format}; > >+ return unless $string; >+ > my $isbn = Business::ISBN->new($string); > > if ( $isbn && $isbn->error != Business::ISBN::BAD_ISBN ) { >@@ -1548,6 +1550,8 @@ sub NormalizeISBN { > sub GetVariationsOfISBN { > my ($isbn) = @_; > >+ return unless $isbn; >+ > my @isbns; > > push( @isbns, NormalizeISBN({ isbn => $isbn }) ); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10500
:
19172
|
19174
|
20732
|
20744
|
21072
|
21257
|
21258
|
22840
|
22841
|
22910
|
22911
|
22918
|
22919
|
27220
|
27221
|
27222
|
27387
|
27388
| 27389