Attachment 27469 Details for Bug 10832 – Bug 10832: FIX Some print notices may not be sent

[patch] Bug 10832: FIX Some print notices may not be sent

Bug-10832-FIX-Some-print-notices-may-not-be-sent.patch (text/plain), 1.59 KB, created by Jonathan Druart on 2014-04-23 13:00:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2014-04-23 13:00:40 UTC

Size: 1.59 KB

patch

obsolete

>From 2047ce78c7709ef30dab091bb409f06d8efffe57 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Thu, 13 Feb 2014 14:54:45 +0100
>Subject: [PATCH] Bug 10832: FIX Some print notices may not be sent
>
>If overdues should be sent to some patron (on the same branch), only the
>first one was notified.
>
>This patch fixes this issue.
>
>Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
>---
> misc/cronjobs/overdue_notices.pl |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl
>index 3778a82..855558d 100755
>--- a/misc/cronjobs/overdue_notices.pl
>+++ b/misc/cronjobs/overdue_notices.pl
>@@ -454,8 +454,6 @@ END_SQL
>     # my $outfile = 'overdues_' . ( $mybranch || $branchcode || 'default' );
>     while ( my $overdue_rules = $rqoverduerules->fetchrow_hashref ) {
>       PERIOD: foreach my $i ( 1 .. 3 ) {
>-            my $print_sent = 0; # We never sent a print notice
>-
>             $verbose and warn "branch '$branchcode', pass $i\n";
>             my $mindays = $overdue_rules->{"delay$i"};    # the notice will be sent after mindays days (grace period)
>             my $maxdays = (
>@@ -576,6 +574,8 @@ END_SQL
>                 @message_transport_types = @{ GetOverdueMessageTransportTypes( q{}, $overdue_rules->{categorycode}, $i) }
>                     unless @message_transport_types;
> 
>+
>+                my $print_sent = 0; # A print notice is not yet sent for this patron
>                 for my $mtt ( @message_transport_types ) {
> 
>                     my $letter = parse_letter(
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 10832: 20817 | 20818 | 20819 | 22815 | 23900 | 25219 | 25223 | 27468 | 27469 | 27496 | 27497 | 27498