Bugzilla – Attachment 27477 Details for
Bug 12131
C4/TmplToken.pm has an unnecessary dependency on Exporter
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
proposed patch
0001-Bug-12131-Remove-unused-dependency-on-Exporter.patch (text/plain), 1.30 KB, created by
Colin Campbell
on 2014-04-23 13:30:00 UTC
(
hide
)
Description:
proposed patch
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2014-04-23 13:30:00 UTC
Size:
1.30 KB
patch
obsolete
>From 8d2dc49cecf7b04fc093907f797147650d706f83 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Wed, 23 Apr 2014 14:23:28 +0100 >Subject: [PATCH] Bug 12131 Remove unused dependency on Exporter > >C4::TmplToken depends on Exporter but does not use any >of its facilities. Removed the dead code so it doesnt >clog up the source and waste compilation time >--- > C4/TmplToken.pm | 15 ++------------- > 1 file changed, 2 insertions(+), 13 deletions(-) > >diff --git a/C4/TmplToken.pm b/C4/TmplToken.pm >index 819d304..2283d16 100644 >--- a/C4/TmplToken.pm >+++ b/C4/TmplToken.pm >@@ -19,13 +19,8 @@ package C4::TmplToken; > > > use strict; >-#use warnings; FIXME - Bug 2505 >+use warnings; > use C4::TmplTokenType; >-require Exporter; >- >-use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS); >- >-############################################################################### > > =head1 NAME > >@@ -37,14 +32,8 @@ This is a class representing a token scanned from an HTML::Template .tmpl file. > > =cut > >-############################################################################### >+our $VERSION = 3.07.00.049; > >-$VERSION = 3.07.00.049; >- >-@ISA = qw(Exporter); >-@EXPORT_OK = qw(); >- >-############################################################################### > > sub new { > my $this = shift; >-- >1.9.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12131
:
27477
|
27518
|
27608