Bugzilla – Attachment 27481 Details for
Bug 12127
Incorrect DataTable types in Holds to Pull list
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 12127 - Incorrect DataTable types in Holds to Pull list
SIGNED-OFF-Bug-12127---Incorrect-DataTable-types-i.patch (text/plain), 2.63 KB, created by
Owen Leonard
on 2014-04-23 13:53:20 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 12127 - Incorrect DataTable types in Holds to Pull list
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2014-04-23 13:53:20 UTC
Size:
2.63 KB
patch
obsolete
>From 68ea4140e8ad4a660be70501b9ca8c352204f728 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Wed, 23 Apr 2014 15:54:36 +1000 >Subject: [PATCH] [SIGNED-OFF] Bug 12127 - Incorrect DataTable types in Holds > to Pull list >Content-Type: text/plain; charset="utf-8" > >This patch explicitly sets the sType in the Holds to Pull list table >for the libraries, itypes, and locations columns. It appears that the >type is automatically being set to "html" when it should be set to >"string". > >It needs to have a sType of "string", since DataTables will strip out >the <br> tags when using "html", and we need them for the regexp >we use to create a more precise filter search. > >_TEST PLAN_ > >Before applying: > >1) Place a "next available" hold on a record with an item available >from one library/branch (e.g. "Branch A") >2) Place a "next available" hold on a record with an item available >from two different libraries/branches >3) Place a "next available" hold on a record with an item available >from three different libraries/branches - one of which is the same >as the library/branch from Step 1. >4) Go to the Holds to Pull List >5) Filter the branches by "Branch A". >6) You should only see the hold from Step 1 - not Step 3. >7) Try filtering on a branch for a hold that has multiple >libraries/branches. (They shouldn't appear when filtering, except >when using the "None" filter). > >Apply the patch. > >After applying: >1) Repeat Steps 4-7 from above. When filtering on "Branch A", you >should be able to see all holds that are available at "Branch A", >even if they are available at other branches (i.e. the holds has >multiple libraries listed). > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../prog/en/modules/circ/pendingreserves.tt | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >index 78df0e4..6a49e1c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >@@ -12,6 +12,9 @@ $(document).ready(function() { > dt_add_type_uk_date(); > [% END %] > var holdst = $("#holdst").dataTable($.extend(true, {}, dataTablesDefaults, { >+ "aoColumnDefs": [ >+ { "sType": "string", "aTargets": [ 4, 8, 9 ] } //Target columns that use <br> separators and pull-down menus. FIXME: Use class names instead of indexes. >+ ] > })); > holdst.fnAddFilters("filter"); > [%# add separateData function to cleanse jQuery select lists by breaking apart strings glued with BR tags and then de-duplicating any repeated library codes %] >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12127
:
27449
|
27481
|
27609