Bugzilla – Attachment 27499 Details for
Bug 7125
can't change tag in frameworks
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 7125 - can't change tag in frameworks
SIGNED-OFF-Bug-7125---cant-change-tag-in-framework.patch (text/plain), 3.20 KB, created by
Bernardo Gonzalez Kriegel
on 2014-04-23 15:42:00 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 7125 - can't change tag in frameworks
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2014-04-23 15:42:00 UTC
Size:
3.20 KB
patch
obsolete
>From bcf1305c9b6d963e556d5a62fc08323d21b3bafb Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 23 Apr 2014 10:52:14 -0400 >Subject: [PATCH] [SIGNED-OFF] Bug 7125 - can't change tag in frameworks > >When you edit an existing tag in a MARC framework the form makes it >appear as if you can change the tag number when in fact you cannot. This >patch changes the template so that the tag number does not appear as an >editable form field during the edit process. > >To test, apply the patch and open an existing MARC framework in >Adminstration -> MARC bibliographic framework. > >- Choose an existing tag from the list and click 'Edit.' >- The line labeled "Tag" should display the tag as text. >- Making a change to any of the tag's details should work correctly. >- Return to the list of the MARC framework's tags. >- Click 'New tag.' >- The line labeled "Tag" should display a blank form field. >- Create a new tag and confirm that it saves correctly. > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Work as describes, on edit and new. >No koha-qa errors >--- > .../prog/en/modules/admin/marctagstructure.tt | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt >index dc4243d..80f3748 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt >@@ -64,7 +64,18 @@ $(document).ready(function() { > <fieldset class="rows"><legend>[% IF ( use_heading_flags_p ) %][% IF ( heading_modify_tag_p ) %]Modify tag <input type="hidden" name="modif" value="1" />[% searchfield %][% END %][% IF ( heading_add_tag_p ) %]Add tag[% END %][% ELSE %][% action %][% END %]</legend> <input type="hidden" name="op" value="add_validate" /> > <input type="hidden" name="frameworkcode" value="[% frameworkcode %]" /> > >- <ol> <li><label for="tagfield" class="required">Tag: </label><input id="tagfield" type="text" name="tagfield" value="[% searchfield %]" maxlength="3" size="3" required="required" class="required" /> <span class="required">Required</span></li> >+ <ol> >+ <li> >+ [% IF ( heading_modify_tag_p ) %] >+ <input type="hidden" name="tagfield" value="[% searchfield %]" /> >+ <span class="label">Tag:</span> >+ [% searchfield %] >+ [% ELSE %] >+ <label for="tagfield" class="required">Tag: </label> >+ <input id="tagfield" type="text" name="tagfield" value="[% searchfield %]" maxlength="3" size="3" required="required" class="required" /> >+ <span class="required">Required</span> >+ [% END %] >+ </li> > <li><label for="liblibrarian">Label for lib: </label><input type="text" id="liblibrarian" name="liblibrarian" value="[% liblibrarian |html %]" size="40" maxlength="100" /></li> > <li><label for="libopac">Label for opac: </label><input type="text" id="libopac" name="libopac" value="[% libopac |html %]" size="40" maxlength="100" /></li> > <li><label for="repeatable">Repeatable: </label> >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7125
:
6132
|
27494
|
27499
|
27654