Bugzilla – Attachment 27515 Details for
Bug 11724
Make Funds/Status on suggestions page sortable/searchable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed off] Bug 11724 - Make Funds/Status on suggestions page sortable/searchable
Signed-off-Bug-11724---Make-FundsStatus-on-suggest.patch (text/plain), 2.27 KB, created by
David Cook
on 2014-04-24 02:42:30 UTC
(
hide
)
Description:
[Signed off] Bug 11724 - Make Funds/Status on suggestions page sortable/searchable
Filename:
MIME Type:
Creator:
David Cook
Created:
2014-04-24 02:42:30 UTC
Size:
2.27 KB
patch
obsolete
>From e643d3fae4f2c4a7f6b03dffefa6d97ec64126b0 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 14 Mar 2014 14:33:51 -0400 >Subject: [PATCH] [Signed off] Bug 11724 - Make Funds/Status on suggestions > page sortable/searchable > >The fund and status columns on the suggestions page are not sortable or >searchable. This patch makes them so. > >This patch also amends the DataTables configuration to use class-based >targeting for sorting types as was decided on the koha-devel list. The >table markup has been modified accordingly. > >To test you must have existing suggestions. Apply the patch and go to >Acquisitions -> Suggestions. View the table of existing suggestions and >confirm that the funds and status columns are sortable and searchable. > >Confirm that the title column correctly ignores articles when sorting. > >Signed-off-by: David Cook <dcook@prosentient.com.au> > >Works as described. >--- > .../prog/en/modules/suggestion/suggestion.tt | 8 +++----- > 1 files changed, 3 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index 2f79255..54001b8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -54,10 +54,8 @@ $(document).ready(function() { > }); > $(".sorted").dataTable($.extend(true, {}, dataTablesDefaults, { > "aoColumnDefs": [ >- { "aTargets": [ 0, -1, -2 ], "bSortable": false, "bSearchable": false }, >- ], >- "aoColumns": [ >- null,{ "sType": "anti-the" },null,null,null,null,null >+ { "aTargets": [ 0 ], "bSortable": false, "bSearchable": false }, >+ { "sType": "anti-the", "aTargets" : [ "anti-the" ] } > ], > "sPaginationType": "four_button" > })); >@@ -469,7 +467,7 @@ h4.local_collapse a { font-size : 80%; text-decoration: none; } fieldset.brief o > <table id="[% suggestion.suggestiontype %]t" class="sorted"> > <thead> > <tr><th> </th> >- <th>Suggestion</th> >+ <th class="anti-the">Suggestion</th> > <th>Suggested by - on</th> > <th>Managed by - on</th> > <th>Library</th> >-- >1.7.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11724
:
26363
|
27515
|
27651