Bugzilla – Attachment 27551 Details for
Bug 9723
Hourly loans don't show time due in OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9723 - Hourly loans don't show time due in OPAC
Bug-9723---Hourly-loans-dont-show-time-due-in-OPAC.patch (text/plain), 10.38 KB, created by
Owen Leonard
on 2014-04-24 16:53:53 UTC
(
hide
)
Description:
Bug 9723 - Hourly loans don't show time due in OPAC
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2014-04-24 16:53:53 UTC
Size:
10.38 KB
patch
obsolete
>From 39c0ad8bade197b47d069706a8fbbab69c186891 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 24 Apr 2014 12:41:29 -0400 >Subject: [PATCH] Bug 9723 - Hourly loans don't show time due in OPAC >Content-Type: text/plain; charset="utf-8" > >Due dates in the OPAC don't display the time items are due, and thus >items which are on hourly loans don't display an accurate due date and >time. This patch corrects this by adding the "with_hours => 1" >parameter. > >To test, enable an hourly loan period for an itemtype in your >collection. View the display of date due on the following pages: > >- Patron details (opac-user.pl) - Log into the OPAC as a user who has > something checked out which circulates by the hour. > >- Bibliographic details (opac-detail.pl) - View the details for an item > which is circulates by the hour and is checked out. > >- Course reserves details (opac-course-details.pl) - View the contents > of a course reserve, one of which should be an item which circulates > by the hour and is checked out. > >All due dates should show both date and time and be formatted correctly. >Test in both prog and Bootstrap themes. > >This solution is less than ideal for libraries who do not use hourly >loans, as the time information is useless and potentially confusing. >It's problematic even for libraries who do use hourly loans, since >probably not all loans are hourly. > >However, without doing a check of each item's circulation policy every >time we display the due date I don't know how you can tell it's an >hourly loan. Assume that items due at 23:59 are non-hourly? >--- > .../bootstrap/en/modules/opac-course-details.tt | 2 +- > .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- > .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 6 +++--- > .../prog/en/modules/opac-course-details.tt | 2 +- > koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 2 +- > koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt | 6 +++--- > 6 files changed, 10 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt >index d5ff4bc..59484ae 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt >@@ -68,7 +68,7 @@ > <td>[% cr.item.itemcallnumber %]</td> > <td>[% cr.item.copynumber %]</td> > <td>[% INCLUDE 'item-status.inc' item=cr.item issue=cr.issue %]</td> >- <td>[% cr.issue.date_due | $KohaDates %]</td> >+ <td>[% cr.issue.date_due | $KohaDates with_hours => 1 %]</td> > <td>[% cr.public_note %]</td> > </tr> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 4abf17e..31c7d22 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -1199,7 +1199,7 @@ > [% IF ( itemdata_copynumber ) %]<td class="copynumber">[% ITEM_RESULT.copynumber %]</td>[% END %] > <td class="status">[% INCLUDE 'item-status-schema-org.inc' item = ITEM_RESULT %][% INCLUDE 'item-status.inc' item = ITEM_RESULT %]</td> > [% IF ( itemdata_itemnotes ) %]<td class="notes" property="description">[% ITEM_RESULT.itemnotes %]</td>[% END %] >- <td class="date_due"><span title="[% ITEM_RESULT.datedue %]">[% ITEM_RESULT.datedue | $KohaDates %]</span></td> >+ <td class="date_due"><span title="[% ITEM_RESULT.datedue %]">[% ITEM_RESULT.datedue | $KohaDates with_hours => 1 %]</span></td> > [% IF ( OPACShowBarcode ) %]<td class="barcode" property="serialNumber">[% ITEM_RESULT.barcode %]</td>[% END %] > [% IF holds_count.defined || show_priority %] > <td class="holds_count"> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >index 95c597c..340d661 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >@@ -172,14 +172,14 @@ > <td class="date_due overdue"> > <span title="[% ISSUE.date_due %]"> > <span class="tdlabel">Date due:</span> >- [% ISSUE.date_due | $KohaDates %] >+ [% ISSUE.date_due | $KohaDates with_hours => 1 %] > </span> > </td> > [% ELSE %] > <td class="date_due"> > <span title="[% ISSUE.date_due %]"> > <span class="tdlabel">Date due:</span> >- [% ISSUE.date_due | $KohaDates %] >+ [% ISSUE.date_due | $KohaDates with_hours => 1 %] > </span> > </td> > [% END %] >@@ -428,7 +428,7 @@ > <td> > <span title="[% OVERDUE.date_due %]"> > <span class="tdlabel">Date due:</span> >- [% OVERDUE.date_due | $KohaDates %] >+ [% OVERDUE.date_due | $KohaDates with_hours => 1 %] > </span> > </td> > [% IF ( OpacRenewalAllowed ) %] >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-course-details.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-course-details.tt >index 39cecbe..0a090ef 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-course-details.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-course-details.tt >@@ -60,7 +60,7 @@ > <td>[% cr.item.itemcallnumber %]</td> > <td>[% cr.item.copynumber %]</td> > <td>[% INCLUDE 'item-status.inc' item=cr.item issue=cr.issue %]</td> >- <td>[% cr.issue.date_due | $KohaDates %]</td> >+ <td>[% cr.issue.date_due | $KohaDates with_hours => 1 %]</td> > <td>[% cr.public_note %]</td> > </tr> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >index 7ffbbd0..47d2248 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >@@ -1581,7 +1581,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () { > [% IF ( itemdata_copynumber ) %]<td class="copynumber">[% ITEM_RESULT.copynumber %]</td>[% END %] > <td class="status">[% INCLUDE 'item-status-schema-org.inc' item = ITEM_RESULT %][% INCLUDE 'item-status.inc' item = ITEM_RESULT %]</td> > [% IF ( itemdata_itemnotes ) %]<td class="notes" property="description">[% ITEM_RESULT.itemnotes %]</td>[% END %] >- <td class="date_due"><span title="[% ITEM_RESULT.datedue %]">[% ITEM_RESULT.datedue | $KohaDates %]</span></td> >+ <td class="date_due"><span title="[% ITEM_RESULT.datedue %]">[% ITEM_RESULT.datedue | $KohaDates with_hours => 1 %]</span></td> > [% IF ( OPACShowBarcode ) %]<td class="barcode" property="serialNumber">[% ITEM_RESULT.barcode %]</td>[% END %] > [% IF holds_count.defined || show_priority %] > <td class="holds_count"> >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt >index e9fe2d2..6c34b9d 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt >@@ -184,9 +184,9 @@ var MSG_CONFIRM_RESUME_HOLDS = _("Are you sure you want to resume all suspended > [% ISSUE.author %] > </span></td> > [% IF ( ISSUE.overdue ) %] >- <td class="date_due overdue"><span title="[% ISSUE.date_due %]">[% ISSUE.date_due | $KohaDates %]</span></td> >+ <td class="date_due overdue"><span title="[% ISSUE.date_due %]">[% ISSUE.date_due | $KohaDates with_hours => 1 %]</span></td> > [% ELSE %] >- <td class="date_due"><span title="[% ISSUE.date_due %]">[% ISSUE.date_due | $KohaDates %]</span></td> >+ <td class="date_due"><span title="[% ISSUE.date_due %]">[% ISSUE.date_due | $KohaDates with_hours => 1 %]</span></td> > [% END %] > [% UNLESS ( item_level_itypes ) %]<td class="itype">[% IF ( ISSUE.imageurl ) %]<img src="[% ISSUE.imageurl %]" title="[% ISSUE.description %]" alt="[% ISSUE.description %]" />[% END %] [% ISSUE.description %]</td>[% END %] > [% IF ( show_barcode ) %]<td class="barcode">[% ISSUE.barcode %]</td>[% END %] >@@ -342,7 +342,7 @@ var MSG_CONFIRM_RESUME_HOLDS = _("Are you sure you want to resume all suspended > [% UNLESS ( item_level_itypes ) %]<td>[% IF ( OVERDUE.imageurl ) %]<img src="[% OVERDUE.imageurl %]" title="[% OVERDUE.description %]" alt="[% OVERDUE.description %]" />[% END %] [% OVERDUE.description %]</td>[% END %] > [% IF ( show_barcode ) %]<td>[% OVERDUE.barcode %]</td>[% END %] > <td>[% OVERDUE.itemcallnumber %]</td> >-<td><span title="[% OVERDUE.date_due %]">[% OVERDUE.date_due | $KohaDates %]</span></td> >+<td><span title="[% OVERDUE.date_due %]">[% OVERDUE.date_due | $KohaDates with_hours => 1 %]</span></td> > [% IF ( OpacRenewalAllowed ) %] > <td> > [% IF ( OVERDUE.debarred ) %]Account frozen >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9723
:
27551
|
27555
|
27959
|
28114