Attachment 27608 Details for Bug 12131 – [PASSED QA] Bug 12131: Remove unused dependency on Exporter

[patch] [PASSED QA] Bug 12131: Remove unused dependency on Exporter

PASSED-QA-Bug-12131-Remove-unused-dependency-on-Ex.patch (text/plain), 1.48 KB, created by Kyle M Hall (khall) on 2014-04-25 11:23:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2014-04-25 11:23:41 UTC

Size: 1.48 KB

patch

obsolete

>From 26dd681bd86728c6a7f71bda1fd391b17a3666fb Mon Sep 17 00:00:00 2001
>From: Colin Campbell <colin.campbell@ptfs-europe.com>
>Date: Wed, 23 Apr 2014 14:23:28 +0100
>Subject: [PATCH] [PASSED QA] Bug 12131: Remove unused dependency on Exporter
>
>C4::TmplToken depends on Exporter but does not use any
>of its facilities. Removed the dead code so it does not
>clog up the source and waste compilation time
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Module still compiles correctly; t/TmplToken.t passes.
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/TmplToken.pm |   15 ++-------------
> 1 files changed, 2 insertions(+), 13 deletions(-)
>
>diff --git a/C4/TmplToken.pm b/C4/TmplToken.pm
>index 819d304..2283d16 100644
>--- a/C4/TmplToken.pm
>+++ b/C4/TmplToken.pm
>@@ -19,13 +19,8 @@ package C4::TmplToken;
> 
> 
> use strict;
>-#use warnings; FIXME - Bug 2505
>+use warnings;
> use C4::TmplTokenType;
>-require Exporter;
>-
>-use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
>-
>-###############################################################################
> 
> =head1 NAME
> 
>@@ -37,14 +32,8 @@ This is a class representing a token scanned from an HTML::Template .tmpl file.
> 
> =cut
> 
>-###############################################################################
>+our $VERSION = 3.07.00.049;
> 
>-$VERSION = 3.07.00.049;
>-
>-@ISA = qw(Exporter);
>-@EXPORT_OK = qw();
>-
>-###############################################################################
> 
> sub new {
>     my $this = shift;
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 12131: 27477 | 27518 | 27608