Attachment 27660 Details for Bug 11631 – [PASSED QA] Bug 11631: Make i18n toolchain ignore useless strings

[patch] [PASSED QA] Bug 11631: Make i18n toolchain ignore useless strings

PASSED-QA-Bug-11631-Make-i18n-toolchain-ignore-use.patch (text/plain), 1.49 KB, created by Katrin Fischer on 2014-04-26 16:31:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-04-26 16:31:02 UTC

Size: 1.49 KB

patch

obsolete

>From 1b2b68832af9e2d88318dca140723472a67e8ef4 Mon Sep 17 00:00:00 2001
>From: Pasi Kallinen <pasi.kallinen@pttk.fi>
>Date: Thu, 24 Apr 2014 11:01:52 +0300
>Subject: [PATCH] [PASSED QA] Bug 11631: Make i18n toolchain ignore useless
> strings
>
>Test:
>1) Update PO files of some lang, xx-YY-*po
>cd misc/translator
>perl translate update xx-YY
>2) Do it again, just in case
>3) rm po/xx-YY*po~
>4) Extract all msgid's, sorted
>cat po/xx-YY*po | egrep "^msgid" | sort | uniq > xx-YY-pre
>5) Apply the patch
>6) Repeat 1-3
>7) Repeat 4 again, other file
>cat po/xx-YY*po | egrep "^msgid" | sort | uniq > xx-YY-post
>8) Do a diff, inspect results, only strings with %s and \s
>diff xx-YY-pre xx-YY-post | less
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Works as described, 380 strings less to 'translate'
>No koha-qa errors.
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Tested according to test plan, works as described.
>---
> misc/translator/xgettext.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/misc/translator/xgettext.pl b/misc/translator/xgettext.pl
>index 032117d..ea75794 100755
>--- a/misc/translator/xgettext.pl
>+++ b/misc/translator/xgettext.pl
>@@ -37,6 +37,7 @@ sub string_negligible_p ($) {
> 	    || $t =~ /^\d+$/			# purely digits
> 	    || $t =~ /^[-\+\.,:;!\?'"%\[\]\|]+$/ # punctuation w/o context
> 	    || $t =~ /^[A-Za-z]$/		# single letters
>+            || $t =~ /^(&[a-z]+;|&#\d+;|&#x[0-9a-fA-F]+;|%%|%s|\s|[[:punct:]])*$/ # html entities,placeholder,punct, ...
> 	)
> }
> 
>-- 
>1.8.3.2

Actions: View | Diff | Splinter Review

Attachments on bug 11631: 24859 | 26478 | 26492 | 26512 | 26522 | 26834 | 27522 | 27527 | 27659 | 27660