Bugzilla – Attachment 27810 Details for
Bug 11023
Automatic item modification by age (Was "Toggle new status for items")
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11023: Don't use the biblioitems fields for the subtitution
Bug-11023-Dont-use-the-biblioitems-fields-for-the-.patch (text/plain), 3.19 KB, created by
Jonathan Druart
on 2014-04-30 08:31:44 UTC
(
hide
)
Description:
Bug 11023: Don't use the biblioitems fields for the subtitution
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2014-04-30 08:31:44 UTC
Size:
3.19 KB
patch
obsolete
>From 0f87b5df85c2bd7247fe5f0403d663a4fdbd8fb8 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 30 Apr 2014 10:30:34 +0200 >Subject: [PATCH] Bug 11023: Don't use the biblioitems fields for the > subtitution > >It's dangerous to allow a change on the biblioitems fields with this >feature. >--- > .../intranet-tmpl/prog/en/modules/tools/toggle_new_status.tt | 8 ++++---- > tools/toggle_new_status.pl | 3 ++- > 2 files changed, 6 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/toggle_new_status.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/toggle_new_status.tt >index 8a0d5ae..7791d6f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/toggle_new_status.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/toggle_new_status.tt >@@ -155,7 +155,7 @@ > <div class="block"> > <select name="condition_field_[% id %]"> > <option value="">Choose a field name</option> >- [% FOR field IN fields %] >+ [% FOR field IN condition_fields %] > [% IF condition.field == field %] > <option value="[% field %]" selected="selected">[% field %]</option> > [% ELSE %] >@@ -176,7 +176,7 @@ > <div class="block"> > <select name="substitution_field_[% id %]"> > <option value="">Choose a field name</option> >- [% FOR field IN fields %] >+ [% FOR field IN substitution_fields %] > [% IF substitution.field == field %] > <option value="[% field %]" selected="selected">[% field %]</option> > [% ELSE %] >@@ -217,7 +217,7 @@ > <div class="block"> > <select name="condition_field"> > <option value="">Choose a field name</option> >- [% FOR field IN fields %] >+ [% FOR field IN condition_fields %] > <option value="[% field %]">[% field %]</option> > [% END %] > </select> >@@ -232,7 +232,7 @@ > <div class="block"> > <select name="substitution_field"> > <option value="">Choose a field name</option> >- [% FOR field IN fields %] >+ [% FOR field IN substitution_fields %] > <option value="[% field %]">[% field %]</option> > [% END %] > </select> >diff --git a/tools/toggle_new_status.pl b/tools/toggle_new_status.pl >index c7b88d4..a37ea1a 100755 >--- a/tools/toggle_new_status.pl >+++ b/tools/toggle_new_status.pl >@@ -111,7 +111,8 @@ my @biblioitem_fields = map { "biblioitems.$_" } C4::Items::biblioitems_columns; > $template->param( > op => $op, > messages => \@messages, >- fields => [ @item_fields, @biblioitem_fields ], >+ condition_fields => [ @item_fields, @biblioitem_fields ], >+ substitution_fields => \@item_fields, > rules => $rules, > ); > >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11023
:
21926
|
21932
|
21982
|
21983
|
22004
|
22386
|
22734
|
22735
|
24068
|
24069
|
24070
|
24146
|
24147
|
24148
|
25767
|
25833
|
26817
|
26818
|
26819
|
26820
|
26821
|
26822
|
26855
|
27810
|
29216
|
29217
|
29218
|
29219
|
29220
|
29221
|
29222
|
31820
|
31821
|
31822
|
33226
|
33227
|
33228
|
33229
|
33230
|
33231
|
33232
|
33233
|
33234
|
33235
|
34782
|
34783
|
34784
|
34785
|
34786
|
34787
|
34788
|
34789
|
34790
|
34791
|
34870
|
34871
|
34872
|
34873
|
34874
|
34875
|
34876
|
34877
|
34878
|
34879
|
34880
|
34881
|
34882
|
34883
|
35375
|
35376
|
41147
|
41148