Bugzilla – Attachment 27822 Details for
Bug 11573
Fine descriptions related to Rentals are untranslatable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 11573 - Make fine display more consistent for rentals
SIGNED-OFF-Bug-11573---Make-fine-display-more-cons.patch (text/plain), 2.26 KB, created by
Katrin Fischer
on 2014-04-30 22:28:33 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 11573 - Make fine display more consistent for rentals
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-04-30 22:28:33 UTC
Size:
2.26 KB
patch
obsolete
>From 455ed7671805e84c9f9dc25fe9ba83725ab4b8b1 Mon Sep 17 00:00:00 2001 >From: Liz Rea <liz@catalyst.net.nz> >Date: Fri, 17 Jan 2014 22:09:30 +1300 >Subject: [PATCH] [SIGNED OFF] Bug 11573 - Make fine display more consistent > for rentals > >To test: > >1. Set up an item type with a rental charge >2. issue an item from that item type >3. Check fines - the rental charge does not show the title of the issued item >4. Renew that item, the renewal charge does show the title of the issued item >5. Apply the patch >6. Repeat steps 1-4, both should show the title of the issued item in the description. > >This change is proposed in order to get rid of some double ups in the title on the boraccount template. > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Tested with rental lines created before and after applying the patch. >After applying the patch it's better, but old lines will still look ok. > >There is still a double up on the title on the 'pay' tab, as we get the >title from the itemnumber and also display the description. I think >getting all the information from the itemnumber for display would be >a bit nicer in the future. Butthis is an improvement. > >Passes tests and QA script. >--- > C4/Circulation.pm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index bd9e1cc..42e00b9 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2907,16 +2907,17 @@ sub AddIssuingCharge { > my $dbh = C4::Context->dbh; > my $nextaccntno = getnextacctno( $borrowernumber ); > my $manager_id = 0; >+ my $item = GetBiblioFromItemNumber($itemnumber); > $manager_id = C4::Context->userenv->{'number'} if C4::Context->userenv; > my $query =" > INSERT INTO accountlines > (borrowernumber, itemnumber, accountno, > date, amount, description, accounttype, > amountoutstanding, manager_id) >- VALUES (?, ?, ?,now(), ?, 'Rental', 'Rent',?,?) >+ VALUES (?, ?, ?,now(), ?, ?, 'Rent',?,?) > "; > my $sth = $dbh->prepare($query); >- $sth->execute( $borrowernumber, $itemnumber, $nextaccntno, $charge, $charge, $manager_id ); >+ $sth->execute( $borrowernumber, $itemnumber, $nextaccntno, $charge, "$item->{'title'} $item->{'barcode'}", $charge, $manager_id ); > } > > =head2 GetTransfers >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11573
:
24473
|
24485
|
24486
|
25715
|
27822
|
27823
|
27824
|
47236
|
47237
|
47238
|
47239
|
47240
|
47241
|
47242
|
47288
|
47289
|
47290
|
47291
|
88549
|
88600
|
88601
|
88602
|
88603
|
88604
|
88605
|
88606
|
88726
|
88727
|
88728
|
88729
|
90231
|
90232
|
90233
|
90234
|
90246
|
90256
|
90313
|
90314
|
90315
|
90316
|
91529
|
91530
|
91531
|
91532
|
91800
|
91801
|
91802
|
91803
|
91804
|
91805
|
91806