Attachment 27825 Details for Bug 12167 – Bug 12167 - Correct faulty test logic

[patch] Bug 12167 - Correct faulty test logic

Bug-12167---Correct-faulty-test-logic.patch (text/plain), 1.44 KB, created by Mark Tompsett on 2014-05-01 03:17:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2014-05-01 03:17:08 UTC

Size: 1.44 KB

patch

obsolete

>From e12d366a94abd217b86e60ec739639b401641860 Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Wed, 30 Apr 2014 23:08:23 -0400
>Subject: [PATCH] Bug 12167 - Correct faulty test logic
>
>GetNewsToDisplay returns a reference to an array of hashes.
>Of course the hash >= 2.
>
>This patch properly checks the scalar size of the array.
>
>TEST PLAN
>---------
>1) prove -v t/db_dependent/NewsChannels.t
>   -- should "work"
>2) apply the patch
>3) prove -v t/db_dependent/NewsChannels.t
>   -- should "fail"
>      This is in preparation for the next patch.
>
>NOTE: I believe this may only work under Ubuntu 12.04
>---
> t/db_dependent/NewsChannels.t |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/NewsChannels.t b/t/db_dependent/NewsChannels.t
>index f0a86e0..7026185 100644
>--- a/t/db_dependent/NewsChannels.t
>+++ b/t/db_dependent/NewsChannels.t
>@@ -132,7 +132,7 @@ my ( $opac_news_count, $arrayref_opac_news ) = get_opac_news( 0, q{}, 'LIB1' );
> ok( $opac_news_count >= 2, 'Successfully tested get_opac_news for LIB1!' );
> 
> # Test GetNewsToDisplay
>-( $opac_news_count, $arrayref_opac_news ) = GetNewsToDisplay( q{}, 'LIB1' );
>-ok( $opac_news_count >= 2, 'Successfully tested GetNewsToDisplay for LIB1!' );
>+( $arrayref_opac_news ) = GetNewsToDisplay( q{}, 'LIB1' );
>+ok( (scalar @$arrayref_opac_news) >= 2, 'Successfully tested GetNewsToDisplay for LIB1! (' . scalar @$arrayref_opac_news . ')' );
> 
> $dbh->rollback;
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 12167: 27825 | 27826 | 30171 | 30172 | 30173 | 30174 | 30175 | 30176 | 30599 | 30600 | 30601 | 30642 | 30663 | 30882 | 30883 | 30884 | 30885 | 31139 | 38721 | 38722 | 38723 | 38724