Bugzilla – Attachment 27879 Details for
Bug 12165
Add description of charges (bug 2546) to Bootstrap OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed-off] Bug 12165: Add descriptions of charges (bug 2546) to Bootstrap Opac theme
Signed-off-Bug-12165-Add-descriptions-of-charges-b.patch (text/plain), 3.62 KB, created by
Marc Véron
on 2014-05-01 15:07:36 UTC
(
hide
)
Description:
[Signed-off] Bug 12165: Add descriptions of charges (bug 2546) to Bootstrap Opac theme
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2014-05-01 15:07:36 UTC
Size:
3.62 KB
patch
obsolete
>From b52d2150a7ee980f9c4ffe17ce9cd3a7e8c7cea5 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Wed, 30 Apr 2014 21:14:50 +0200 >Subject: [PATCH] [Signed-off] Bug 12165: Add descriptions of charges (bug > 2546) to Bootstrap Opac theme >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >1) Create an account with lots of different charges, fines, fees, etc. >2) Look at the accouts tab in the prog OPAC theme >3) Compare the page to bootstrap theme >4) Verify display is now the same > >In my tests I found some things that could still be improved, >but for the goal is to make all OPAC themes behave the same. > >Tested by changing accounttype in table accountlines to all possible values like Pay, Pay00, Pay01 etc. >Both themes display the same values, e.g. "Payment, thanks (cash via SIP2)" for Pay00 >Signed-off-by: Marc Véron <veron@veron.ch> >--- > .../opac-tmpl/bootstrap/en/modules/opac-account.tt | 21 +++++++++++++++++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt >index aa70431..256a6d3 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt >@@ -48,8 +48,23 @@ > [% FOREACH ACCOUNT_LINE IN ACCOUNT_LINES %] > [% IF ( ACCOUNT_LINE.odd ) %]<tr class="highlight">[% ELSE %]<tr>[% END %] > <td>[% ACCOUNT_LINE.date | $KohaDates %]</td> >- <td>[% ACCOUNT_LINE.description %] >- [% IF ( ACCOUNT_LINE.title ) %][% ACCOUNT_LINE.title |html %][% END %]</td> >+ <td> >+ [% SWITCH ACCOUNT_LINE.accounttype %] >+ [% CASE 'Pay' %]Payment,thanks >+ [% CASE 'Pay00' %]Payment,thanks (cash via SIP2) >+ [% CASE 'Pay01' %]Payment,thanks (VISA via SIP2) >+ [% CASE 'Pay02' %]Payment,thanks (credit card via SIP2) >+ [% CASE 'N' %]New Card >+ [% CASE 'F' %]Fine >+ [% CASE 'A' %]Account management fee >+ [% CASE 'M' %]Sundry >+ [% CASE 'L' %]Lost Item >+ [% CASE 'W' %]Writeoff >+ [% CASE %][% ACCOUNT_LINE.accounttype %] >+ [%- END -%] >+ [%- IF ACCOUNT_LINE.description %], [% ACCOUNT_LINE.description %][% END %] >+ [% IF line.title %]([% line.title |html_entity %])[% END %] >+ </td> > [% IF ( ACCOUNT_LINE.amountcredit ) %]<td class="credit">[% ELSE %]<td class="debit">[% END %][% ACCOUNT_LINE.amount %]</td> > [% IF ( ACCOUNT_LINE.amountoutstandingcredit ) %]<td class="credit">[% ELSE %]<td class="debit">[% END %][% ACCOUNT_LINE.amountoutstanding %]</td> > </tr> >@@ -67,4 +82,4 @@ > </div> <!-- / .main --> > > [% INCLUDE 'opac-bottom.inc' %] >-[% BLOCK jsinclude %][% END %] >\ No newline at end of file >+[% BLOCK jsinclude %][% END %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12165
:
27821
|
27879
|
28100
|
28101