Bugzilla – Attachment 27936 Details for
Bug 11668
Untranslatable "Total" in borrowers stats and other reports
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11668: make hardcoded strings in reports/borrowers_stats.pl translatable
Bug-11668-make-hardcoded-strings-in-reportsborrowe.patch (text/plain), 1.55 KB, created by
Galen Charlton
on 2014-05-05 04:55:48 UTC
(
hide
)
Description:
Bug 11668: make hardcoded strings in reports/borrowers_stats.pl translatable
Filename:
MIME Type:
Creator:
Galen Charlton
Created:
2014-05-05 04:55:48 UTC
Size:
1.55 KB
patch
obsolete
>From a6b2f669cd82fec4d14501541fe6fed1d1c743ff Mon Sep 17 00:00:00 2001 >From: Galen Charlton <gmc@esilibrary.com> >Date: Mon, 5 May 2014 04:52:33 +0000 >Subject: [PATCH] Bug 11668: make hardcoded strings in > reports/borrowers_stats.pl translatable > >To test: > >[1] Generate the PO files for the language of your choice. >[2] Supply translations for the "Total" and "TOTAL" strings > in the $LANG-messages.op file. >[3] Install the translation. >[4] Change the staff interface to the chosen language. >[5] Run the borrowers statistics report and export the > results to CSV. >[5] Verfiy that the strings "Total" and "TOTAL" are > replaced with the translation made in step 2. > >Signed-off-by: Galen Charlton <gmc@esilibrary.com> >--- > reports/borrowers_stats.pl | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/reports/borrowers_stats.pl b/reports/borrowers_stats.pl >index 8181285..1c53add 100755 >--- a/reports/borrowers_stats.pl >+++ b/reports/borrowers_stats.pl >@@ -36,6 +36,7 @@ use Date::Calc qw( > Today > Add_Delta_YM > ); >+use Koha::I18N; > > =head1 NAME > >@@ -96,7 +97,7 @@ if ($do_it) { > foreach my $col ( @$cols ) { > print $col->{coltitle}.$sep; > } >- print "Total\n"; >+ print gettext("Total") . "\n"; > foreach my $line ( @$lines ) { > my $x = $line->{loopcell}; > print $line->{rowtitle}.$sep; >@@ -106,7 +107,7 @@ if ($do_it) { > print $line->{totalrow}; > print "\n"; > } >- print "TOTAL"; >+ print gettext("TOTAL"); > $cols = @$results[0]->{loopfooter}; > foreach my $col ( @$cols ) { > print $sep.$col->{totalcol}; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11668
:
27936
|
31425
|
31438
|
31512
|
31513
|
32698
|
32699
|
32711
|
32712
|
32713
|
36794