Attachment 27938 Details for Bug 11209 – Bug 11209: Check if a notice has been already sent today

[patch] Bug 11209: Check if a notice has been already sent today

Bug-11209-Check-if-a-notice-has-been-already-sent-.patch (text/plain), 1.47 KB, created by Marcel de Rooy on 2014-05-05 08:04:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2014-05-05 08:04:50 UTC

Size: 1.47 KB

patch

obsolete

>From 51e466a8523a5064f11ebadab31a2b58e73a03c6 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Tue, 3 Dec 2013 12:17:50 +0100
>Subject: [PATCH] Bug 11209: Check if a notice has been already sent today
>Content-Type: text/plain; charset=utf-8
>
>The previous patch checks if a notice has already been sent when the
>current notices has been sent in queue. Which is wrong!
>We have to check if a similar notice has been sent today.
>
>This patch has been created after an observation on a production server:
>If a user place on holds several items, he will receive 1 SMS per hold.
>Here we only want 1 SMS for all holds.
>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> C4/Letters.pm |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Letters.pm b/C4/Letters.pm
>index aa823f4..23b7fdd 100644
>--- a/C4/Letters.pm
>+++ b/C4/Letters.pm
>@@ -1033,9 +1033,9 @@ sub _is_duplicate {
>         WHERE message_transport_type = ?
>         AND borrowernumber = ?
>         AND letter_code = ?
>-        AND CAST(time_queued AS date) = CAST(? AS date)
>+        AND CAST(time_queued AS date) = CAST(NOW() AS date)
>         AND status="sent"
>-    |, {}, $message->{message_transport_type}, $message->{borrowernumber}, $message->{letter_code}, $message->{time_queued} );
>+    |, {}, $message->{message_transport_type}, $message->{borrowernumber}, $message->{letter_code} );
>     return $count;
> }
> 
>-- 
>1.7.7.6

Actions: View | Diff | Splinter Review

Attachments on bug 11209: 22752 | 22762 | 23255 | 27827 | 27828 | 27919 | 27937 | 27938 | 27939