Bugzilla – Attachment 27964 Details for
Bug 7825
Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7825: FIX the force value for the bootstrap theme
Bug-7825-FIX-the-force-value-for-the-bootstrap-the.patch (text/plain), 2.33 KB, created by
Jonathan Druart
on 2014-05-06 09:46:04 UTC
(
hide
)
Description:
Bug 7825: FIX the force value for the bootstrap theme
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2014-05-06 09:46:04 UTC
Size:
2.33 KB
patch
obsolete
>From fc4173f0ca4d925c39bb310a027782c397cbfa4b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Tue, 14 Jan 2014 09:38:32 +0100 >Subject: [PATCH] Bug 7825: FIX the force value for the bootstrap theme > >If the pref was set to 'force', the item selection was not shown. >.copiesrow should be hidden before showing specific #copiesrow_ID > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Passes all tests and QA script. > >Works on template level, tested with Boostrap and Prog theme >with all 3 possible seetings of OPACItemHolds: > >1) no = offer only title level holds >2) yes = offer both title and item level holds >3) force = offer only item level holds > >Also ran some additional tests on the Boostrap theme with >deactivated Javascript. > >Note: I like this, but I think when "force" is selected the >item list needs to be shown by default. I am also not happy about >preselecting the first item. >--- > .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >index 5b1e313..e82540c 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >@@ -424,15 +424,6 @@ > } > }); > >- [% FOREACH bibitemloo IN bibitemloop %] >- [% IF bibitemloo.holdable %] >- [% IF OPACItemHolds == 'force' %] >- $("#copiesrow_[% bibitemloo.biblionumber %]").show(); >- [% END %] >- [% END %] >- [% END %] >- >- > // click on a first td check the confirmjs checkbox > $("td.hold").click(function(e){ > if(e.target.tagName.toLowerCase() == 'td'){ >@@ -446,6 +437,14 @@ > // Hides all 'specific copy' table rows on load. > $(".copiesrow").hide(); > >+ [% FOREACH bibitemloo IN bibitemloop %] >+ [% IF bibitemloo.holdable %] >+ [% IF OPACItemHolds == 'force' %] >+ $("#copiesrow_[% bibitemloo.biblionumber %]").show(); >+ [% END %] >+ [% END %] >+ [% END %] >+ > // Insert reasons for forced hold notes > $(".forcenotesreason").each(function(){ > biblioNum = suffixOf($(this).attr("id"), "_"); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7825
:
8641
|
8645
|
8646
|
12881
|
12883
|
12884
|
12885
|
12915
|
12920
|
12921
|
12922
|
12923
|
13305
|
13306
|
13307
|
13340
|
13341
|
13350
|
15032
|
15033
|
15034
|
15035
|
15606
|
15607
|
18435
|
18436
|
18878
|
18879
|
18903
|
18904
|
18920
|
18924
|
18925
|
18926
|
18927
|
18928
|
22635
|
22877
|
23631
|
24218
|
24270
|
24271
|
24538
|
24539
|
24540
|
24541
|
24542
|
24578
|
24579
|
24591
|
24592
|
27961
|
27962
|
27963
| 27964 |
27965
|
27966