Bugzilla – Attachment 27996 Details for
Bug 12198
Guarantor search makes incorrect and unnecessary call to GetMemberIssuesAndFines
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12198: remove unnecessary call to GetMemberIssuesAndFines from guarantor search
Bug-12198-remove-unnecessary-call-to-GetMemberIssu.patch (text/plain), 1.55 KB, created by
Galen Charlton
on 2014-05-06 20:10:22 UTC
(
hide
)
Description:
Bug 12198: remove unnecessary call to GetMemberIssuesAndFines from guarantor search
Filename:
MIME Type:
Creator:
Galen Charlton
Created:
2014-05-06 20:10:22 UTC
Size:
1.55 KB
patch
obsolete
>From 1f043c0d673aea7deadaf0280c9f3c65633e585c Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 6 May 2014 12:26:49 -0400 >Subject: [PATCH] Bug 12198: remove unnecessary call to > GetMemberIssuesAndFines from guarantor search > >The script members/guarantor_search.pl made the following call: >my ($od,$issue,$fines)=GetMemberIssuesAndFines($results->[$i]{'borrowerid'}); > >Not only does this call always fail because borrowerid is not a valid >key, but the results are never even used in the template! > >Test Plan: >1) Apply this patch >2) Verify the gurantor search works as before, > No changes in behavior should be noted > >Signed-off-by: Galen Charlton <gmc@esilibrary.com> >--- > members/guarantor_search.pl | 3 --- > 1 file changed, 3 deletions(-) > >diff --git a/members/guarantor_search.pl b/members/guarantor_search.pl >index 59ea5b1..42d36a7 100755 >--- a/members/guarantor_search.pl >+++ b/members/guarantor_search.pl >@@ -71,7 +71,6 @@ if ($member ne ''){ > > for (my $i=0; $i < $count; $i++){ > #find out stats >- my ($od,$issue,$fines)=GetMemberIssuesAndFines($results->[$i]{'borrowerid'}); > my $guarantorinfo=uc($results->[$i]{'surname'})." , ".ucfirst($results->[$i]{'firstname'}); > my %row = ( > background => $background, >@@ -94,8 +93,6 @@ if ($member ne ''){ > dateofbirth =>format_date($results->[$i]{'dateofbirth'}), > #fi op > >- odissue => "$od/$issue", >- fines => $fines, > borrowernotes => $results->[$i]{'borrowernotes'}); > if ( $background ) { $background = 0; } else {$background = 1; } > push(@resultsdata, \%row); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12198
:
27988
|
27989
|
27996
|
27997
|
27998
|
28108
|
28109
|
28110