Bugzilla – Attachment 28041 Details for
Bug 11843
Manual subscription history doesn't seem to work as expected
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11843: (follow-up) fix unit test in t/db_dependent/Serials.t
Bug-11843-follow-up-fix-unit-test-in-tdbdependentS.patch (text/plain), 1.39 KB, created by
Galen Charlton
on 2014-05-07 21:57:11 UTC
(
hide
)
Description:
Bug 11843: (follow-up) fix unit test in t/db_dependent/Serials.t
Filename:
MIME Type:
Creator:
Galen Charlton
Created:
2014-05-07 21:57:11 UTC
Size:
1.39 KB
patch
obsolete
>From 070b94558d23e29edd58eb9fd436b9704100bf1c Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Wed, 7 May 2014 10:40:58 +0200 >Subject: [PATCH] Bug 11843: (follow-up) fix unit test in > t/db_dependent/Serials.t > >Signed-off-by: Galen Charlton <gmc@esilibrary.com> >--- > t/db_dependent/Serials.t | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Serials.t b/t/db_dependent/Serials.t >index f1f5d9d..ab466e6 100644 >--- a/t/db_dependent/Serials.t >+++ b/t/db_dependent/Serials.t >@@ -234,11 +234,13 @@ is( @others, 6, "GetSerials returns all serials not arrived and not missing if c > $subscription = C4::Serials::GetSubscription($subscriptionid); # Retrieve the updated subscription > > my @serialseqs; >-for my $am ( reverse @arrived_missing ) { >- if ( grep {/^$am->{status}$/} qw( 4 41 42 43 44 5 ) ) { >+for my $am ( @arrived_missing ) { >+ if ( grep {/^$am->{status}$/} qw( 4 41 42 43 44 ) ) { > push @serialseqs, $am->{serialseq} >+ } elsif ( grep {/^$am->{status}$/} qw( 5 ) ) { >+ push @serialseqs, 'not issued ' . $am->{serialseq}; > } > } >-is( $subscription->{missinglist}, 'not issued ' . join('; ', @serialseqs), "subscription missinglist is updated after ModSerialStatus" ); >+is( $subscription->{missinglist}, join('; ', @serialseqs), "subscription missinglist is updated after ModSerialStatus" ); > > $dbh->rollback; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11843
:
27713
|
27714
|
28006
|
28039
|
28040
|
28041
|
28127
|
28128