Bugzilla – Attachment 28099 Details for
Bug 4068
Accepting a suggestion hides 'pending' tab
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 4068 - Accepting a suggestion hides 'pending' tab
Bug-4068---Accepting-a-suggestion-hides-pending-ta.patch (text/plain), 1.78 KB, created by
Jonathan Druart
on 2014-05-08 14:38:52 UTC
(
hide
)
Description:
Bug 4068 - Accepting a suggestion hides 'pending' tab
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2014-05-08 14:38:52 UTC
Size:
1.78 KB
patch
obsolete
>From 9500353f237fd60bfe79656b176472eec87bf0b0 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 6 May 2014 08:49:15 -0400 >Subject: [PATCH] Bug 4068 - Accepting a suggestion hides 'pending' tab > >1) Moving a suggestion from status 'pending' to 'accepted > - After saving only tab 'accepted' is shown. >2) Moving a suggestion back from 'accepted' to 'pending' > - After saving only tab 'pending' is shown. > >Test Plan: >1) Verify the bug by taking the actions listed above >2) Apply this patch >3) Verify the bug no longer exists > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >It is not very elegant but I have nothing else to suggest. >--- > suggestion/suggestion.pl | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > >diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl >index c0327ad..9efd015 100755 >--- a/suggestion/suggestion.pl >+++ b/suggestion/suggestion.pl >@@ -182,7 +182,20 @@ elsif ($op eq "change" ) { > $$suggestion_ref{'suggestionid'}=$suggestionid; > &ModSuggestion($suggestion_ref); > } >- $op = 'else'; >+ my $params; >+ foreach my $key ( >+ qw( >+ displayby branchcode title author isbn publishercode copyrightdate >+ collectiontitle suggestedby suggesteddate_from suggesteddate_to >+ manageddate_from manageddate_to accepteddate_from >+ accepteddate_to budgetid >+ ) >+ ) >+ { >+ $params .= $key . '=' . $input->param($key) . '&' >+ if $input->param($key); >+ } >+ print $input->redirect("/cgi-bin/koha/suggestion/suggestion.pl?$params"); > }elsif ($op eq "delete" ) { > foreach my $delete_field (@editsuggestions) { > &DelSuggestion( $borrowernumber, $delete_field,'intranet' ); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 4068
:
27969
|
27974
| 28099