Bugzilla – Attachment 28151 Details for
Bug 11629
Add ability to update not for loan status on checkin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11629 [QA Followup]
Bug-11629-QA-Followup.patch (text/plain), 3.85 KB, created by
Kyle M Hall (khall)
on 2014-05-09 16:58:00 UTC
(
hide
)
Description:
Bug 11629 [QA Followup]
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-05-09 16:58:00 UTC
Size:
3.85 KB
patch
obsolete
>From add4e0395e0591ece36cc188dd0ba643e5d5833b Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 17 Apr 2014 07:08:55 -0400 >Subject: [PATCH] Bug 11629 [QA Followup] > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> > >Changed the syspref.sql file to remove one of the doubled >up UNIMARCAuthrityField100 that slipped in with an earlier >patch on this bug. > >Passes all tests and QA script, also t/db_dependent/Circulation_issue.t > >Tested with items that had >- no notforloan value set >- notforloan value not used in updateNotforLoanStatusOnCheckin >- the notforloan value defined in UpdateNotForLoanStatusOnCheckin > >Also verified it works the same, when the item was checked out or >not checked out on return. > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >--- > installer/data/mysql/sysprefs.sql | 3 +-- > t/db_dependent/Circulation_issue.t | 3 ++- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 27eee15..ef7a8ed 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -408,12 +408,11 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('TrackClicks','0',NULL,'Track links clicked','Integer'), > ('TransfersMaxDaysWarning','3',NULL,'Define the days before a transfer is suspected of having a problem','Integer'), > ('TransferWhenCancelAllWaitingHolds','0',NULL,'Transfer items when cancelling all waiting holds','YesNo'), >-('UpdateNotForLoanStatusOnCheckin', '', 'NULL', 'This is a list of value pairs. When an item is checked in, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value. E.g. ''-1: 0'' will cause an item that was set to ''Ordered'' to now be available for loan. Each pair of values should be on a separate line.', 'Free'), > ('UNIMARCAuthorityField100','afrey50 ba0',NULL,'Define the contents of UNIMARC authority control field 100 position 08-35','Textarea'), >-('UNIMARCAuthorityField100','afrey50 ba0',NULL,NULL,'Textarea'), > ('UNIMARCAuthorsFacetsSeparator',', ',NULL,'UNIMARC authors facets separator','short'), > ('UNIMARCField100Language','fre',NULL,'UNIMARC field 100 default language','short'), > ('UniqueItemFields','barcode','','Space-separated list of fields that should be unique (used in acquisition module for item creation). Fields must be valid SQL column names of items table','Free'), >+('UpdateNotForLoanStatusOnCheckin', '', 'NULL', 'This is a list of value pairs. When an item is checked in, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value. E.g. ''-1: 0'' will cause an item that was set to ''Ordered'' to now be available for loan. Each pair of values should be on a separate line.', 'Free'), > ('UpdateTotalIssuesOnCirc','0',NULL,'Whether to update the totalissues field in the biblio on each circ.','YesNo'), > ('uppercasesurnames','0',NULL,'If ON, surnames are converted to upper case in patron entry form','YesNo'), > ('URLLinkText','',NULL,'Text to display as the link anchor in the OPAC','free'), >diff --git a/t/db_dependent/Circulation_issue.t b/t/db_dependent/Circulation_issue.t >index 0e83794..a37321f 100644 >--- a/t/db_dependent/Circulation_issue.t >+++ b/t/db_dependent/Circulation_issue.t >@@ -342,7 +342,8 @@ AddReturn('barcode_1', undef, undef, undef, '2014-04-01 23:42'); > $return = $dbh->selectrow_hashref("SELECT * FROM old_issues LIMIT 1" ); > ok( $return->{returndate} eq '2014-04-01 23:42:00', "Item returned with a return date of '2014-04-01 23:42' has that return date" ); > >-my ($biblionumber, $biblioitemnumber, $itemnumber) = C4::Items::AddItem( >+my $itemnumber; >+($biblionumber, $biblioitemnumber, $itemnumber) = C4::Items::AddItem( > { > barcode => 'barcode_3', > itemcallnumber => 'callnumber3', >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11629
:
24848
|
24849
|
24962
|
24963
|
24964
|
25229
|
25580
|
25581
|
25582
|
25583
|
27233
|
27244
|
27245
|
27246
|
27247
|
27248
|
27249
|
27250
|
27251
|
27252
|
28147
|
28148
|
28149
|
28150
| 28151 |
28152