Bugzilla – Attachment 28213 Details for
Bug 11634
Allow renewal of item with unfilled holds if other available items can fill those holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11634 [QA Followup] - Unit Tests
Bug-11634-QA-Followup---Unit-Tests.patch (text/plain), 1.69 KB, created by
Kyle M Hall (khall)
on 2014-05-13 14:56:33 UTC
(
hide
)
Description:
Bug 11634 [QA Followup] - Unit Tests
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-05-13 14:56:33 UTC
Size:
1.69 KB
patch
obsolete
>From 14d65447e67ce1f8329cbfb0c3ffdf2ddea464b1 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 4 Mar 2014 12:58:28 -0500 >Subject: [PATCH] Bug 11634 [QA Followup] - Unit Tests > >These new unit tests will fail due to the fact that Koha::Database >uses a separate dbh handle than C4::Context->dbh >--- > t/db_dependent/Circulation.t | 9 ++++++++- > 1 files changed, 8 insertions(+), 1 deletions(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 6b25208..7b02763 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -9,7 +9,7 @@ use C4::Items; > use C4::Members; > use C4::Reserves; > >-use Test::More tests => 48; >+use Test::More tests => 50; > > BEGIN { > use_ok('C4::Circulation'); >@@ -261,6 +261,13 @@ C4::Context->dbh->do("DELETE FROM accountlines"); > $title, $checkitem, $found > ); > >+ C4::Context->set_preference('AllowRenewalIfOtherItemsAvailable', 1 ); >+ ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber); >+ is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds'); >+ ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2); >+ is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds'); >+ C4::Context->set_preference('AllowRenewalIfOtherItemsAvailable', 0 ); >+ > ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber); > is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved'); > is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)'); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11634
:
24866
|
25032
|
25148
|
25822
|
25825
|
25826
|
25827
|
25837
|
28212
|
28213
|
28214
|
31706
|
31707
|
31708
|
31709
|
32034
|
32035
|
32036
|
32037
|
32875
|
32876
|
32877
|
32878
|
33492