Attachment 28303 Details for Bug 12274 – Bug 12274 - Closed invoices not properly handled on invoice details page

[patch] Bug 12274 - Closed invoices not properly handled on invoice details page

Bug-12274---Closed-invoices-not-properly-handled-o.patch (text/plain), 1.56 KB, created by Jacek Ablewicz on 2014-05-17 09:12:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jacek Ablewicz

Created: 2014-05-17 09:12:01 UTC

Size: 1.56 KB

patch

obsolete

>From 9b03f5f406c3e1498636d430f6668132de8c2e63 Mon Sep 17 00:00:00 2001
>From: Jacek Ablewicz <abl@biblos.pk.edu.pl>
>Date: Sat, 17 May 2014 10:30:15 +0200
>Subject: [PATCH] Bug 12274 - Closed invoices not properly handled on invoice
> details page
>
>Trivial fix for small regression (closed invoices are displayed as
>"Open" on details page, and it's not possible to reopen the closed
>invoice using "Save" button) introduced by bug 10613.
>
>Test plan:
>
>1) Create and close some invoices
>2) Note that closed invoices are erroneously displayed as "Open"
>on individual invoice[s] details page
>3) Apply patch
>4) Check previously closed invoices; their status on details page
>should now be properly displayed as "Closed on ..." (and an option
>for reopening would reappear as well)
>5) Ensure that "Close" / "Reopen" checkboxes followed by "Save" button
>do work as expected for individual open / closed invoices respectivelly.
>---
> acqui/invoice.pl |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/acqui/invoice.pl b/acqui/invoice.pl
>index 95065c9..84b7834 100755
>--- a/acqui/invoice.pl
>+++ b/acqui/invoice.pl
>@@ -151,7 +151,7 @@ $template->param(
>     booksellerid     => $details->{'booksellerid'},
>     datereceived     => $details->{'datereceived'},
>     billingdate      => C4::Dates->new($details->{'billingdate'}, "iso")->output(),
>-    invoiceclosedate => $details->{'invoiceclosedate'},
>+    invoiceclosedate => $details->{'closedate'},
>     shipmentcost     => $details->{'shipmentcost'},
>     orders_loop      => \@orders_loop,
>     foot_loop        => \@foot_loop,
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 12274: 28303 | 28351 | 28352 | 28395 | 28396