Attachment 28397 Details for Bug 11365 – Bug 11365: Label card element title texts cannot be translated

[patch] Bug 11365: Label card element title texts cannot be translated

Bug-11365-Label-card-element-title-texts-cannot-be.patch (text/plain), 5.04 KB, created by Jonathan Druart on 2014-05-21 10:35:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2014-05-21 10:35:27 UTC

Size: 5.04 KB

patch

obsolete

>From 1fe8559add9c5c93e5df87fc1516ec003435410a Mon Sep 17 00:00:00 2001
>From: Pasi Kallinen <pasi.kallinen@pttk.fi>
>Date: Tue, 6 May 2014 11:49:39 +0300
>Subject: [PATCH] Bug 11365: Label card element title texts cannot be
> translated
>
>To test:
>
>1) cd misc/translator
>2) perl translate update xx-YY
>3) check that there's no msgid that contains the patron card label
>   element title texts in po/xx-YY-i-staff-t-prog-v-3006000.po
>4) apply patch
>5) perl translate update xx-YY
>6) check po/xx-YY-i-staff-t-prog-v-3006000.po that it contains the
>   msgid. (search for "BLOCK translate_card_element")
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Work as described. Tested updating po file, translating and installing
>language, checked on tools page.
>No errors
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> .../prog/en/modules/patroncards/manage.tt          | 26 ++++++++++++++++------
> 1 file changed, 19 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt
>index 5acaf68..3e04ee3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt
>@@ -1,3 +1,15 @@
>+[% BLOCK translate_card_element %]
>+[%  SWITCH element %]
>+[%   CASE 'layout'    %]layout
>+[%   CASE 'Layouts'   %]Layouts
>+[%   CASE 'template'  %]template
>+[%   CASE 'Templates' %]Templates
>+[%   CASE 'profile'   %]profile
>+[%   CASE 'Profiles'  %]Profiles
>+[%   CASE 'batch'     %]batch
>+[%   CASE 'Batches'   %]Batches
>+[%  END %]
>+[% END %]
>     [% INCLUDE 'doc-head-open.inc' %]
>     <title>Koha &rsaquo; Tools &rsaquo; Patron cards &rsaquo; Manage patron card elements</title>
>     [% INCLUDE 'doc-head-close.inc' %]
>@@ -7,7 +19,7 @@
>             function DeleteConfirm() {
>                 var element_id = selected_layout("delete");
>                 if (element_id>-1) {
>-                    var msg = _("Are you sure you want to delete %s %s?").format("[% card_element %]", element_id);
>+                    var msg = _("Are you sure you want to delete %s %s?").format("[% PROCESS translate_card_element element=card_element %]", element_id);
>                     var answer = confirm(msg);
>                     if (answer) {
>                         window.location = "/cgi-bin/koha/patroncards/manage.pl?op=delete&card_element=[% card_element %]&element_id=" + element_id;
>@@ -64,7 +76,7 @@
>                         return(document.layouts.action[selected[0]].value);
>                     }
>                     else {
>-                        alert(_("Please select only one %s to %s.").format("[% card_element %]", op));
>+                        alert(_("Please select only one %s to %s.").format("[% PROCESS translate_card_element element=card_element %]", op));
>                         return (-1);
>                     }
>                 }
>@@ -73,7 +85,7 @@
>                         return(document.layouts.action.value);
>                     }
>                 };
>-                alert(_("Please select a %s.").format("[% card_element %]"));
>+                alert(_("Please select a %s.").format("[% PROCESS translate_card_element element=card_element %]"));
>                 return (-1);
>             };
> 
>@@ -101,7 +113,7 @@
>         <a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo;
>         <a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a> &rsaquo;
>         <a href="/cgi-bin/koha/patroncards/home.pl">Patron card creator</a> &rsaquo;
>-        Manage card [% card_element_title %]
>+        Manage card [% PROCESS translate_card_element element=card_element_title %]
>     </div>
>     <div id="doc3" class="yui-t2">
>         <div id="bd">
>@@ -114,7 +126,7 @@
>                             <div class="hint">Current library: [% LoginBranchname %]</div>
>                             [% IF ( table_loop ) %]
>                             <form name="layouts" action="/cgi-bin/koha/manage.pl?card_element=[% card_element %]">
>-                            <h2>Currently Available [% card_element_title %]</h2>
>+                            <h2>Currently Available [% PROCESS translate_card_element element=card_element_title %]</h2>
>                             <table>
>                                 [% FOREACH table_loo IN table_loop %]
>                                 [% IF ( table_loo.header_fields ) %]
>@@ -146,8 +158,8 @@
>                             </form>
>                             [% ELSE %]
>                         <div class="dialog message">
>-                            <h4>There are no [% card_element_title %] currently available.</h4>
>-                            <p>Use the toolbar above to create a new [% card_element %].</p></div>
>+                            <h4>There are no [% PROCESS translate_card_element element=card_element_title %] currently available.</h4>
>+                            <p>Use the toolbar above to create a new [% PROCESS translate_card_element element=card_element %].</p></div>
>                             [% END %]
>                         </div>
>                     </div>
>-- 
>2.0.0.rc2

Actions: View | Diff | Splinter Review

Attachments on bug 11365: 27960 | 28300 | 28397