Attachment 28456 Details for Bug 12229 – [PASSED QA] Bug 12229: fix to prevent adding of invalid records in marc file

[patch] [PASSED QA] Bug 12229: fix to prevent adding of invalid records in marc file

PASSED-QA-Bug-12229-fix-to-prevent-adding-of-inval.patch (text/plain), 1.41 KB, created by Kyle M Hall (khall) on 2014-05-23 10:58:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2014-05-23 10:58:07 UTC

Size: 1.41 KB

patch

obsolete

>From 62e1e5b0421dc40a034b8ea95f537ccd34dce3a5 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?St=C3=A9phane=20Delaune?= <stephane.delaune@biblibre.com>
>Date: Mon, 12 May 2014 16:58:14 +0200
>Subject: [PATCH] [PASSED QA] Bug 12229: fix to prevent adding of invalid records in marc file
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Work as described. No errors
>
>Test:
>1. Edit record, add 100.000 chars text to 500a
>2. xml export produce the record,
>3. mrc export do not produce the record,
>warning on log
>export.pl: record (number 2025) length 102668 is larger than the MARC spec allows (99999 bytes) at...
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> tools/export.pl |    5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
>diff --git a/tools/export.pl b/tools/export.pl
>index 9bbed0b..1a055b0 100755
>--- a/tools/export.pl
>+++ b/tools/export.pl
>@@ -394,6 +394,11 @@ if ( $op eq "export" ) {
>                     print "\n";
>                 }
>                 else {
>+                    my (@result_build_tag) = MARC::File::USMARC::_build_tag_directory($record);
>+                    if ($result_build_tag[2] > 99999) {
>+                        warn "record (number $recordid) length ".$result_build_tag[2]." is larger than the MARC spec allows (99999 bytes)";
>+                        next;
>+                    }
>                     print $record->as_usmarc();
>                 }
>             }
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 12229: 28180 | 28410 | 28456