Bugzilla – Attachment 28523 Details for
Bug 11169
OPAC: Display acquisition details
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11169: (follow-up) add more unit tests
Bug-11169-follow-up-add-more-unit-tests.patch (text/plain), 2.16 KB, created by
Galen Charlton
on 2014-05-28 18:32:46 UTC
(
hide
)
Description:
Bug 11169: (follow-up) add more unit tests
Filename:
MIME Type:
Creator:
Galen Charlton
Created:
2014-05-28 18:32:46 UTC
Size:
2.16 KB
patch
obsolete
>From 20b59296931b44475f58b33c19984e9e18ddf1a1 Mon Sep 17 00:00:00 2001 >From: Galen Charlton <gmc@esilibrary.com> >Date: Wed, 28 May 2014 17:45:11 +0000 >Subject: [PATCH] Bug 11169: (follow-up) add more unit tests > >This patch adds direct unit tests of the new biblionumber filter >for SearchOrders. It also moves the ordernumber filter test >to the rest of the SearchOrders tests. > >To test: > >[1] Verify that prove -v t/db_dependent/Acquisition.t passes. > >Signed-off-by: Galen Charlton <gmc@esilibrary.com> >--- > t/db_dependent/Acquisition.t | 22 ++++++++++++++++------ > 1 file changed, 16 insertions(+), 6 deletions(-) > >diff --git a/t/db_dependent/Acquisition.t b/t/db_dependent/Acquisition.t >index 8936ec4..837024a 100755 >--- a/t/db_dependent/Acquisition.t >+++ b/t/db_dependent/Acquisition.t >@@ -8,7 +8,7 @@ use POSIX qw(strftime); > > use C4::Bookseller qw( GetBookSellerFromId ); > >-use Test::More tests => 77; >+use Test::More tests => 79; > > BEGIN { > use_ok('C4::Acquisition'); >@@ -727,6 +727,21 @@ $search_orders = SearchOrders({ > }); > is( scalar (@$search_orders), 0, "SearchOrders with pending and ordered params gets only pending ordered orders (bug 11170)" ); > >+$search_orders = SearchOrders({ >+ ordernumber => $ordernumbers[4] >+}); >+is( scalar (@$search_orders), 1, "SearchOrders takes into account the ordernumber filter" ); >+ >+$search_orders = SearchOrders({ >+ biblionumber => $biblionumber4 >+}); >+is( scalar (@$search_orders), 1, "SearchOrders takes into account the biblionumber filter" ); >+ >+$search_orders = SearchOrders({ >+ biblionumber => $biblionumber4, >+ pending => 1 >+}); >+is( scalar (@$search_orders), 0, "SearchOrders takes into account the biblionumber and pending filters" ); > > # > # Test GetBudgetByOrderNumber >@@ -798,11 +813,6 @@ $search_orders = SearchOrders({ > }); > is( scalar (@$search_orders), 3, "SearchOrders with pending and ordered params gets only pending ordered orders. After closing the basket, orders are marked as 'ordered' (bug 11170)" ); > >-$search_orders = SearchOrders({ >- ordernumber => $ordernumbers[4] >-}); >-is( scalar (@$search_orders), 1, "SearchOrders takes into account the ordernumber filter" ); >- > # > # Test AddClaim > # >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11169
:
22594
|
22595
|
25654
|
25657
|
26082
|
26083
|
26084
|
26330
|
26331
|
26332
|
26343
|
26344
|
26345
|
27018
|
27019
|
27020
|
28045
|
28419
|
28483
|
28511
|
28512
|
28522
| 28523 |
28524
|
33522