Attachment 28615 Details for Bug 12151 – Bug 12151: Remove uses of smartmatch operator from Koha/Solr/QueryBuilder.pm

[patch] Bug 12151: Remove uses of smartmatch operator from Koha/Solr/QueryBuilder.pm

Bug-12151-Remove-uses-of-smartmatch-operator-from-.patch (text/plain), 1.47 KB, created by Tomás Cohen Arazi (tcohen) on 2014-06-02 14:37:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2014-06-02 14:37:12 UTC

Size: 1.47 KB

patch

obsolete

>From 819111bcfaa1c46a9d437b59f86f6243d4cd7018 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@gmail.com>
>Date: Mon, 2 Jun 2014 11:14:11 -0300
>Subject: [PATCH] Bug 12151: Remove uses of smartmatch operator from
> Koha/Solr/QueryBuilder.pm
>
>Just that.
>
>Regards
>To+
>---
> Koha/SearchEngine/Solr/QueryBuilder.pm | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
>diff --git a/Koha/SearchEngine/Solr/QueryBuilder.pm b/Koha/SearchEngine/Solr/QueryBuilder.pm
>index b3e75c9..ba5547f 100644
>--- a/Koha/SearchEngine/Solr/QueryBuilder.pm
>+++ b/Koha/SearchEngine/Solr/QueryBuilder.pm
>@@ -60,16 +60,12 @@ sub build_advanced_query {
>         # And others
>         $index_name = @$indexes[$i] if @$indexes[$i];
>         my $operator = defined @$operators[$i-1] ? @$operators[$i-1] : 'AND';
>-        for ( uc ( $operator ) ) {
>-            when ('OR'){
>-                $q .= BuildTokenString($index_name, $kw, 'OR');
>-            }
>-            when ('NOT'){
>-                $q .= BuildTokenString($index_name, $kw, 'NOT');
>-            }
>-            default {
>-                $q .= BuildTokenString($index_name, $kw, 'AND');
>-            }
>+        if ( uc ( $operator ) eq 'OR' ) {
>+            $q .= BuildTokenString($index_name, $kw, 'OR');
>+        } elsif ( uc ( $operator ) eq 'NOT' ) {
>+            $q .= BuildTokenString($index_name, $kw, 'NOT');
>+        } else {
>+            $q .= BuildTokenString($index_name, $kw, 'AND');
>         }
>         $i = $i + 1;
>     }
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 12151: 28580 | 28581 | 28615 | 28616 | 29013 | 29014 | 29015 | 29016 | 29487 | 29488 | 29489 | 29490 | 29519 | 29520 | 29521 | 29522 | 29523