Attachment 28665 Details for Bug 12337 – Bug 12337 - Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message.

[patch] Bug 12337 - Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message.

Bug-12337---Multi-clicking-the-renewal-buttons-on-.patch (text/plain), 2.65 KB, created by Biblibre Sandboxes on 2014-06-04 22:07:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Biblibre Sandboxes

Created: 2014-06-04 22:07:05 UTC

Size: 2.65 KB

patch

obsolete

>From f21927dd69ed989fa0d55ab7f148fb2c1a3074b6 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 30 May 2014 07:17:25 -0400
>Subject: [PATCH] Bug 12337 - Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message.
>
>Each time the "renew all" or "renew or return" buttons are click, the
>renewal process is triggered. If the patron only has one renewal left,
>and the button is multi-clicked, the librarian may receive a
>"renewal failed" message even though the renewal did occur. In
>addition, this can just unwanted multiple consecutive renewals
>as well.
>
>Test Plan:
>1) Check out an item to a patron that can have 1 renewal
>2) Click the "renew all" button multiple times, fast and furiously
>3) Note the "renewal failed" messaged
>4) Apply this patch
>5) Repeat steps 1 and 2
>6) Note the item is now renewed without the failure message
>
>Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
>---
> .../prog/en/modules/circ/circulation.tt            |    3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>index 6805126..75e05b3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>@@ -26,6 +26,7 @@ var MSG_EXPORT_SELECT_CHECKOUTS = _("You must select checkout(s) to export");
> [% IF ( borrowernumber ) %]if($.cookie("holdfor") != [% borrowernumber %]){ $.cookie("holdfor",null, { path: "/", expires: 0 }); }[% ELSE %]$.cookie("holdfor",null, { path: "/", expires: 0 });[% END %]
> [% UNLESS ( borrowernumber ) %][% UNLESS ( CGIselectborrower ) %]window.onload=function(){ $('#findborrower').focus(); };[% END %][% END %]
> 	 $(document).ready(function() {
>+        $('#issues-form').preventDoubleFormSubmit();
>         $('#patronlists').tabs([% IF ( UseTablesortForCirc ) %]{
>             // Correct table sizing for tables hidden in tabs
>             // http://www.datatables.net/examples/api/tabs_and_scrolling.html
>@@ -717,7 +718,7 @@ No patron matched <span class="ex">[% message %]</span>
> 
> <div id="checkouts">
> [% IF ( issuecount ) %]
>-    <form name="issues" action="/cgi-bin/koha/reserve/renewscript.pl" method="post" class="checkboxed">
>+    <form id="issues-form" name="issues" action="/cgi-bin/koha/reserve/renewscript.pl" method="post" class="checkboxed">
>     <input type="hidden" value="circ" name="destination" />
>     <input type="hidden" name="cardnumber" value="[% cardnumber %]" />
>     <input type="hidden" name="borrowernumber" value="[% borrowernumber %]" />
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 12337: 28568 | 28665 | 28709