Bugzilla – Attachment 28670 Details for
Bug 11801
In transit hold items incorrectly labeled as "Waiting to be pulled" on request.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 11801: In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl
PASSED-QA-Bug-11801-In-transit-hold-items-incorrec.patch (text/plain), 2.00 KB, created by
Martin Renvoize (ashimema)
on 2014-06-05 07:44:50 UTC
(
hide
)
Description:
[PASSED QA] Bug 11801: In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2014-06-05 07:44:50 UTC
Size:
2.00 KB
patch
obsolete
>From ec0c6fab8cdac92accf642ab495ff65862977967 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Thu, 20 Feb 2014 10:06:36 -0500 >Subject: [PATCH] [PASSED QA] Bug 11801: In transit hold items incorrectly > labels as "Waiting to be pulled" on request.pl > >If an item needs to be transferred to fill a hold, the hold will be >listed as 'Waiting to be pulled" while it is in transit. > >Test Plan: >1) Place a hold for pickup at another library >2) Check in the item, confirm the hold transfer >3) View the holds for that record ( request.pl ) >4) Note the priority is "In transit" and the status is 'Waiting to be > pulled". >5) Apply this patch >6) Reload the holds page >7) Note the status is now "Item being transferred to $branch" > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > reserve/request.pl | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index 1b303c7..a86e0e7 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -476,7 +476,12 @@ foreach my $biblionumber (@biblionumbers) { > $reserve{'itemnumber'} = $res->{'itemnumber'}; > $reserve{'wbrname'} = $branches->{$res->{'branchcode'}}->{'branchname'}; > if($reserve{'holdingbranch'} eq $reserve{'wbrcode'}){ >- $reserve{'atdestination'} = 1; >+ # Just because the holdingbranch matches the reserve branch doesn't mean the item >+ # has arrived at the destination, check for an open transfer for the item as well >+ my ( $transfertwhen, $transfertfrom, $transferto ) = C4::Circulation::GetTransfers( $res->{itemnumber} ); >+ if ( not $transferto or $transferto ne $res->{branchcode} ) { >+ $reserve{'atdestination'} = 1; >+ } > } > # set found to 1 if reserve is waiting for patron pickup > $reserve{'found'} = 1 if $res->{'found'} eq 'W'; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11801
:
25507
|
25508
|
25509
|
26086
|
26481
|
28664
| 28670