Bugzilla – Attachment 28750 Details for
Bug 12380
can't tab to save buttons on add item
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 12380 - can't tab to save buttons on add item
SIGNED-OFF-Bug-12380---cant-tab-to-save-buttons-on.patch (text/plain), 2.22 KB, created by
Nicole C. Engard
on 2014-06-10 00:28:09 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 12380 - can't tab to save buttons on add item
Filename:
MIME Type:
Creator:
Nicole C. Engard
Created:
2014-06-10 00:28:09 UTC
Size:
2.22 KB
patch
obsolete
>From 4184cfa9604837be683c419533d6e7d1fec1ad9e Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 9 Jun 2014 08:58:30 -0400 >Subject: [PATCH] [SIGNED-OFF] Bug 12380 - can't tab to save buttons on add item > >Many form elements on the add item page are giving a tabindex of "1" by >the script. This seems to make it impossible to tab through the add item >form fields onto the save buttons. I don't see a reason to set an >explicit tabindex of "1," so this patch removes it. > >To test, apply the patch and open an item for editing. Try tabbing >through the add item form fields. It should be possible to tab through >the fields and onto the submit buttons at the bottom. Test again when >adding a new item. > >Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> >--- > cataloguing/additem.pl | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > >diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl >index 268ef66..7110f7f 100755 >--- a/cataloguing/additem.pl >+++ b/cataloguing/additem.pl >@@ -154,8 +154,8 @@ sub generate_subfield_form { > my $input = new CGI; > $value = $input->param('barcode'); > } >- my $attributes_no_value = qq(tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="50" maxlength="$subfield_data{maxlength}" ); >- my $attributes_no_value_textarea = qq(tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" rows="5" cols="64" ); >+ my $attributes_no_value = qq(id="$subfield_data{id}" name="field_value" class="input_marceditor" size="50" maxlength="$subfield_data{maxlength}" ); >+ my $attributes_no_value_textarea = qq(id="$subfield_data{id}" name="field_value" class="input_marceditor" rows="5" cols="64" ); > my $attributes = qq($attributes_no_value value="$value" ); > > if ( $subfieldlib->{authorised_value} ) { >@@ -224,7 +224,6 @@ sub generate_subfield_form { > -override => 1, > -size => 1, > -multiple => 0, >- -tabindex => 1, > -id => "tag_".$tag."_subfield_".$subfieldtag."_".$index_subfield, > -class => "input_marceditor", > ); >-- >1.7.2.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12380
:
28734
|
28750
|
28759