Attachment 28850 Details for Bug 10519 – Bug 10519 - Suggestions: 'Organize by' and correct display of tab descriptions broken

[patch] Bug 10519 - Suggestions: 'Organize by' and correct display of tab descriptions broken

Bug-10519---Suggestions-Organize-by-and-correct-di.patch (text/plain), 1.13 KB, created by Jacek Ablewicz on 2014-06-13 19:42:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jacek Ablewicz

Created: 2014-06-13 19:42:26 UTC

Size: 1.13 KB

patch

obsolete

>From 0c0f910dc7a519885158e60fadfce175eb480f24 Mon Sep 17 00:00:00 2001
>From: Jacek Ablewicz <abl@biblos.pk.edu.pl>
>Date: Fri, 13 Jun 2014 21:27:38 +0200
>Subject: [PATCH] Bug 10519 - Suggestions: 'Organize by' and correct display
> of tab descriptions broken
>
>Follow-up to fix additional suggestion statuses, which are not working
>properly due to
>
>   416:  borrowernumber           => $input->param('borrowernumber'),
>
>being evaluated in list context inside $template->param() call arguments.
>---
> suggestion/suggestion.pl |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl
>index 2af64ab..fa5fe3f 100755
>--- a/suggestion/suggestion.pl
>+++ b/suggestion/suggestion.pl
>@@ -413,7 +413,7 @@ foreach my $field ( qw(managedby acceptedby suggestedby budgetid) ) {
> 
> $template->param(
>     %hashlists,
>-    borrowernumber           => $input->param('borrowernumber'),
>+    borrowernumber           => ($input->param('borrowernumber') // undef),
>     SuggestionStatuses       => GetAuthorisedValues('SUGGEST_STATUS'),
> );
> output_html_with_http_headers $input, $cookie, $template->output;
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 10519: 19300 | 19327 | 19340 | 19341 | 19355 | 19356 | 19364 | 28763 | 28850 | 28851 | 28852 | 29598 | 29599 | 29686