Attachment 28904 Details for Bug 12407 – [SIGNED-OFF] Bug 12407 - phone label or data switched

[patch] [SIGNED-OFF] Bug 12407 - phone label or data switched

SIGNED-OFF-Bug-12407---phone-label-or-data-switche.patch (text/plain), 3.96 KB, created by Nicole C. Engard on 2014-06-17 13:40:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nicole C. Engard

Created: 2014-06-17 13:40:01 UTC

Size: 3.96 KB

patch

obsolete

>From ff17e05268c162c27d72e289f6a73ea2fb6764b6 Mon Sep 17 00:00:00 2001
>From: Brendon Ford <brendon.ford@manhattan.edu>
>Date: Thu, 12 Jun 2014 20:28:28 -0400
>Subject: [PATCH] [SIGNED-OFF] Bug 12407 - phone label or data switched
>
>Fix for switched phone numbers on patron details page.
>
>This patch fixes switched phone numbers on patron details page and also makes phone number labels more uniform.
>
>To Test:
>
>1. Apply the patch.
>2. Create/modify a patron entering some unique data into the "Secondary phone:" and "Other phone:" fields (different data for each).
>3. Save the patron record.
>4. Go to the patrons details page and make sure the data entered into the "Secondary phone:" field is displaying next to the "Secondary phone:" label and that the data entered into the "Other phone:" field is displaying next to the "Other phone:" label.
>
>Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
>---
> .../prog/en/modules/members/moremember-brief.tt | 6 +++---
> .../prog/en/modules/members/moremember.tt | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt
>index c9fb845..b46424e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt
>@@ -33,13 +33,13 @@
> [% IF ( emailpro ) %]<li>Organization email: [% emailpro %]</li>[% END %]
> [% ELSE %]
> [% IF ( phone ) %]<li>Primary phone: [% phone %]</li>[% END %]
>- [% IF ( mobile ) %]<li>Secondary phone: [% mobile %]</li>[% END %]
>- [% IF ( phonepro ) %]<li>Other phone: [% phonepro %]</li>[% END %]
>+ [% IF ( phonepro ) %]<li>Secondary phone: [% phonepro %]</li>[% END %]
>+ [% IF ( mobile ) %]<li>Other phone: [% mobile %]</li>[% END %]
> [% END %]
> 
> [% IF ( P ) %]
> [% IF ( phone ) %]<li>Primary phone: [% phone %]</li>[% END %]
>- [% IF ( mobile ) %]<li>Secondary mobile: [% mobile %]</li>[% END %]
>+ [% IF ( mobile ) %]<li>Other phone: [% mobile %]</li>[% END %]
> [% END %]
> 	[% IF ( fax ) %]<li>Fax: [% fax %]</li>[% END %]
> [% UNLESS ( I ) %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>index 345c728..d42ae59 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>@@ -225,13 +225,13 @@ function validate1(date) {
> [% IF ( emailpro ) %]<li>Organization email: [% emailpro %]</li>[% END %]
> [% ELSE %]
> [% IF ( phone ) %]<li>Primary phone: [% phone %]</li>[% END %]
>- [% IF ( mobile ) %]<li>Secondary phone: [% mobile %]</li>[% END %]
>- [% IF ( phonepro ) %]<li>Other phone: [% phonepro %]</li>[% END %]
>+ [% IF ( phonepro ) %]<li>Secondary phone: [% phonepro %]</li>[% END %]
>+ [% IF ( mobile ) %]<li>Other phone: [% mobile %]</li>[% END %]
> [% END %]
> 
> [% IF ( P ) %]
> [% IF ( phone ) %]<li>Primary phone: [% phone %]</li>[% END %]
>- [% IF ( mobile ) %]<li>Secondary phone: [% mobile %]</li>[% END %]
>+ [% IF ( mobile ) %]<li>Other phone: [% mobile %]</li>[% END %]
> [% END %] 	
> 	[% IF ( fax ) %]<li>Fax: [% fax %]</li>[% END %]
> [% UNLESS ( I ) %]
>-- 
>1.7.2.3

Actions: View | Diff | Splinter Review

Attachments on bug 12407: 28785 | 28786 | 28878 | 28879 | 28904 | 30393 | 30394 | 30549