Bugzilla – Attachment 28944 Details for
Bug 12261
Staff client next/previous links lead to unknown record
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 12261: Staff client next/previous links lead to unknown record
SIGNED-OFF-Bug-12261-Staff-client-nextprevious-lin.patch (text/plain), 2.11 KB, created by
Owen Leonard
on 2014-06-18 15:03:23 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 12261: Staff client next/previous links lead to unknown record
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2014-06-18 15:03:23 UTC
Size:
2.11 KB
patch
obsolete
>From dd79e58dc2636c09899489e1b599a3c2a7a26deb Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Juhani=20Sepp=C3=A4l=C3=A4?= <jseppal@student.uef.fi> >Date: Tue, 17 Jun 2014 13:05:10 +0300 >Subject: [PATCH] [SIGNED-OFF] Bug 12261: Staff client next/previous links > lead to unknown record >Content-Type: text/plain; charset="utf-8" > >When using Staff client next/previous links after a search : >If the current record is the last of the results, clicking on "next" >will lead to the page of an unknown record with message : > >The record you requested does not exist (NaN). > >To test: >1) Do an intranet catalog search that has more than 1 results. >2) Click on the last search result and then click the "Next"-button from > the top-left navigation. >3) Confirm that you get thrown to a page with the message: "The record > you requested does not exist (NaN).". >4) Apply patch. >5) Repeat steps 1 - 2. >6) Confirm that the navigation button for "Next" is greyed out. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >This patch fixes the problem with last result in both single pages of >search results and multiple pages of search results. >--- > koha-tmpl/intranet-tmpl/js/browser.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/js/browser.js b/koha-tmpl/intranet-tmpl/js/browser.js >index b56ff9f..4d0fc36 100644 >--- a/koha-tmpl/intranet-tmpl/js/browser.js >+++ b/koha-tmpl/intranet-tmpl/js/browser.js >@@ -81,7 +81,7 @@ KOHA.browser = function (searchid, biblionumber) { > } else { > prevbutton = '<a href="#" id="browse-previous" class="browse-button">« ' + BROWSER_PREVIOUS + '</a>'; > } >- if (me.curPos === me.searchCookie.results.length && me.searchCookie.total == me.curPos + me.searchCookie.offset) { >+ if (me.curPos === me.searchCookie.pagelen - 1) { > nextbutton = '<span id="browse-next" class="browse-button">' + BROWSER_NEXT + ' »</span>'; > } else { > nextbutton = '<a href="#" id="browse-next" class="browse-button">' + BROWSER_NEXT + ' »</a>'; >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12261
:
28882
|
28907
|
28944
|
29100
|
29207