Attachment 28947 Details for Bug 12332 – Bug 12332: Fix for tab "Purchase suggestions" not lighting up

[patch] Bug 12332: Fix for tab "Purchase suggestions" not lighting up

Bug-12332-Fix-for-tab-Purchase-suggestions-not-lig.patch (text/plain), 2.51 KB, created by Jonathan Druart on 2014-06-18 15:20:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2014-06-18 15:20:22 UTC

Size: 2.51 KB

patch

obsolete

>From 92e0afa4f0689a2e4e282bbb9e3e824d633b4b71 Mon Sep 17 00:00:00 2001
>From: Viktor Sarge <viktor.sarge@regionhalland.se>
>Date: Mon, 16 Jun 2014 13:09:10 +0100
>Subject: [PATCH] Bug 12332: Fix for tab "Purchase suggestions" not lighting up
>
>This patch changes the file purchase-suggestions.pl with "suggestionsview => 1" for the template parameter.
>In circ-menu.inc i changed the condition from "suggestions" to "suggestionsview" since it seemed to conflict with the existing variable suggestions (and in that case only highlighting the tab when there were suggestions).
>
>Please note that I fixed the troubles with the tab "Fines" in a separate patch 9245.
>
>Test plan:
>1) Verify that "Purchase suggestions" does not light up as it should when clicked.
>2) Install the patch.
>3) Verify that the tab "Purchase suggestions" now actually light up when clicked.
>
>Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 2 +-
> members/purchase-suggestions.pl                        | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>index 6162293..7505d06 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>@@ -83,7 +83,7 @@
>     [% IF EnableBorrowerFiles %]
>         [% IF ( borrower_files ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/files.pl?borrowernumber=[% borrowernumber %]">Files</a></li>
>     [% END %]
>-    [% IF (  suggestions ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/purchase-suggestions.pl?borrowernumber=[% borrowernumber %]">Purchase<br/>suggestions</a></li>
>+    [% IF (  suggestionsview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/purchase-suggestions.pl?borrowernumber=[% borrowernumber %]">Purchase<br/>suggestions</a></li>
> </ul></div>
> [% END %]
> 
>diff --git a/members/purchase-suggestions.pl b/members/purchase-suggestions.pl
>index a624b68..e19da5b 100755
>--- a/members/purchase-suggestions.pl
>+++ b/members/purchase-suggestions.pl
>@@ -47,6 +47,7 @@ foreach my $key ( keys %$borrower ) {
>     $template->param( $key => $borrower->{$key} );
> }
> $template->param(
>+    suggestionsview  => 1,
>     categoryname => $borrower->{'description'},
>     branchname   => GetBranchName( $borrower->{'branchcode'} ),
> );
>-- 
>2.0.0.rc2

Actions: View | Diff | Splinter Review

Attachments on bug 12332: 28865 | 28920 | 28947