Bugzilla – Attachment 29033 Details for
Bug 11431
Custom notification sounds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11431 [4] - Add the ability to choose the elements that trigger an audio alert
Bug-11431-4---Add-the-ability-to-choose-the-elemen.patch (text/plain), 5.27 KB, created by
Kyle M Hall (khall)
on 2014-06-19 14:04:42 UTC
(
hide
)
Description:
Bug 11431 [4] - Add the ability to choose the elements that trigger an audio alert
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-06-19 14:04:42 UTC
Size:
5.27 KB
patch
obsolete
>From 0c7218b5a9120be4c1c41daca6743df93af4c725 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 19 Jun 2014 09:44:24 -0400 >Subject: [PATCH] Bug 11431 [4] - Add the ability to choose the elements that trigger an audio alert > >--- > installer/data/mysql/updatedatabase.pl | 5 ++++- > .../prog/en/includes/doc-head-close.inc | 17 ++++++++++------- > .../en/modules/admin/preferences/circulation.pref | 15 +++++++++++++++ > 3 files changed, 29 insertions(+), 8 deletions(-) > >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index b8a650e..0989c2d 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -8568,7 +8568,10 @@ if ( CheckVersion($DBversion) ) { > INSERT IGNORE INTO systempreferences ( variable, value, options, explanation, type ) VALUES > ( 'OverrideAudioAlertWarning', '', NULL, 'URL to an audio file to replace the default warning sound.', 'free' ), > ( 'OverrideAudioAlertAction', '', NULL, 'URL to an audio file to replace the default "action required" sound.', 'free' ), >- ( 'OverrideAudioAlertSuccess', '', NULL, 'URL to an audio file to replace the default success sound.', 'free' ) >+ ( 'OverrideAudioAlertSuccess', '', NULL, 'URL to an audio file to replace the default success sound.', 'free' ), >+ ( 'AudioAlertSelectorWarning', '.audio-alert-warning', NULL, 'List of jQuery selectors that should trigger warning alert', 'free' ), >+ ( 'AudioAlertSelectorAction', '.audio-alert-action', NULL, 'List of jQuery selectors that should trigger action alert', 'free' ), >+ ( 'AudioAlertSelectorSuccess', '.audio-alert-success', NULL, 'List of jQuery selectors that should trigger successs alert', 'free' ) > }); > > print "Upgrade to $DBversion done (Bug 11169 - Add OPACAcquisitionDetails syspref)\n"; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc >index 90d4c76..d8465cd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc >@@ -66,20 +66,23 @@ > [% IF AudioAlerts %] > <script type="text/javascript"> > //<![CDATA[ >- var AUDIO_ALERT_PATH = "[% interface %]/[% theme %]/sound/"; >- var AUDIO_ALERT_ACTION = "[% Koha.Preference('OverrideAudioAlertAction') || 'opening.ogg' %]"; >- var AUDIO_ALERT_WARNING = "[% Koha.Preference('OverrideAudioAlertWarning') || 'critical.ogg' %]"; >- var AUDIO_ALERT_SUCCESS = "[% Koha.Preference('OverrideAudioAlertSuccess') || 'beep.ogg' %]"; >+ var AUDIO_ALERT_PATH = '[% interface %]/[% theme %]/sound/'; >+ var AUDIO_ALERT_ACTION = '[% Koha.Preference("OverrideAudioAlertAction") || "opening.ogg" %]'; >+ var AUDIO_ALERT_WARNING = '[% Koha.Preference("OverrideAudioAlertWarning") || "critical.ogg" %]'; >+ var AUDIO_ALERT_SUCCESS = '[% Koha.Preference("OverrideAudioAlertSuccess") || "beep.ogg" %]'; >+ var AUDIO_ALERT_SELECTOR_ACTION = '[% Koha.Preference("AudioAlertSelectorAction") | replace( "'", "\\'" ) %]'; >+ var AUDIO_ALERT_SELECTOR_WARNING = '[% Koha.Preference("AudioAlertSelectorWarning") | replace( "'", "\\'" ) %]'; >+ var AUDIO_ALERT_SELECTOR_SUCCESS = '[% Koha.Preference("AudioAlertSelectorSuccess") | replace( "'", "\\'" ) %]'; > //]]> > > $( document ).ready(function() { >- if ( $(".audio-alert-action").length ) { >+ if ( $( AUDIO_ALERT_SELECTOR_ACTION ).length ) { > playSoundAction(); > } >- else if ( $(".audio-alert-warning").length ) { >+ else if ( $( AUDIO_ALERT_SELECTOR_WARNING ).length ) { > playSoundWarning(); > } >- else if ( $(".audio-alert-success").length ) { >+ else if ( $( AUDIO_ALERT_SELECTOR_SUCCESS ).length ) { > playSoundSuccess(); > } > }); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >index 8251f4b..f14d1cd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >@@ -641,3 +641,18 @@ Circulation: > - pref: OverrideAudioAlertSuccess > class: url > - (This should be a complete URL, starting with <code>http://</code>) >+ - >+ - Use the following selectors for <i>warning</i> alerts >+ - pref: AudioAlertSelectorWarning >+ class: url >+ - (This should be a list of jQuery selectors, separated by commas) >+ - >+ - Use the following selectors for <i>action</i> alerts >+ - pref: AudioAlertSelectorAction >+ class: url >+ - (This should be a list of jQuery selectors, separated by commas) >+ - >+ - Use the following selectors for <i>success</i> alerts >+ - pref: AudioAlertSelectorSuccess >+ class: url >+ - (This should be a list of jQuery selectors, separated by commas) >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11431
:
29030
|
29031
|
29032
|
29033
|
29034
|
29035
|
29036
|
29037
|
29038
|
29039
|
29119
|
29120
|
29404
|
29764
|
29765
|
29766
|
29767
|
29768
|
29769
|
31145
|
31146
|
31147
|
31148
|
31149
|
31150
|
34637
|
34638
|
34639
|
34640
|
34641
|
34642
|
34643
|
34644
|
34645
|
34646
|
34647
|
34648
|
34649
|
34650
|
34651
|
34652
|
34653
|
34717
|
34718
|
34719
|
34720
|
34864
|
34865
|
34866
|
34867
|
35843
|
35844
|
35845
|
35846
|
38547
|
38548
|
40726
|
40727
|
40728
|
40729
|
40730
|
40731
|
40732
|
41634
|
41661
|
41662
|
42678
|
42679
|
42680
|
42681
|
42682
|
42683
|
42684
|
42685
|
42686
|
42687
|
42688
|
42689
|
42696
|
43753
|
43754
|
43755
|
43756
|
43757
|
43758
|
43759
|
43760
|
43761
|
43762
|
43763
|
43764
|
43765
|
43817
|
43820
|
43821
|
43822
|
43823
|
43824
|
43825
|
43887
|
43888
|
43889
|
43890
|
43891
|
43892
|
43893
|
43894
|
43895
|
43896
|
43897
|
43898
|
43899
|
43900
|
43901
|
43902
|
43903
|
44391
|
44392
|
44393
|
44394
|
44395
|
44396
|
44397
|
44398
|
44399
|
44400
|
44401
|
44402
|
44404
|
44405
|
44407
|
44408
|
44409
|
44411
|
44412
|
44599
|
45135