Bugzilla – Attachment 29113 Details for
Bug 12411
Encoding broken in the syspref template plugin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12411 - Encoding broken in the syspref template plugin
bug_12411.patch (text/plain), 1.26 KB, created by
Kyle M Hall (khall)
on 2014-06-20 16:07:55 UTC
(
hide
)
Description:
Bug 12411 - Encoding broken in the syspref template plugin
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-06-20 16:07:55 UTC
Size:
1.26 KB
patch
obsolete
>From 04f355235bc33ccc01c65066084b6dcc7a0a8828 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Thu, 12 Jun 2014 17:04:03 +0200 >Subject: [PATCH] [PASSED QA] Bug 12411: Preferences values should be utf8 encoded >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Test plan: >Fill OPACMySummaryNote or NoLoginInstructions with something like "éà ç" >and verify the display is broken. > >Signed-off-by: Paola Rossi <paola.rossi@cineca.it> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > Koha/Template/Plugin/Koha.pm | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > >diff --git a/Koha/Template/Plugin/Koha.pm b/Koha/Template/Plugin/Koha.pm >index 2eff9f1..6b95e3b 100644 >--- a/Koha/Template/Plugin/Koha.pm >+++ b/Koha/Template/Plugin/Koha.pm >@@ -18,6 +18,7 @@ package Koha::Template::Plugin::Koha; > # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > > use Modern::Perl; >+use Encode qw( encode ); > > use base qw( Template::Plugin ); > >@@ -41,7 +42,7 @@ is necessary. > > sub Preference { > my ( $self, $pref ) = @_; >- return C4::Context->preference( $pref ); >+ return encode('UTF-8', C4::Context->preference( $pref ) ); > } > > 1; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12411
:
28824
|
29058
|
29112
| 29113