Attachment 29147 Details for Bug 12462 – [PASSED QA] Bug 12462: Fix some POD errors

[patch] [PASSED QA] Bug 12462: Fix some POD errors

PASSED-QA-Bug-12462-Fix-some-POD-errors.patch (text/plain), 2.40 KB, created by Katrin Fischer on 2014-06-22 19:51:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-06-22 19:51:15 UTC

Size: 2.40 KB

patch

obsolete

>From 69dcbb088e5453f6f4e66978e69d4aaf259fd4ae Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@gmail.com>
>Date: Fri, 20 Jun 2014 16:52:59 -0300
>Subject: [PATCH] [PASSED QA] Bug 12462: Fix some POD errors
>
>Bug 12041 made xt/author/podcorrectness.t consider files in the 'Koha' namespace.
>Some of them where failing. This patch fixes some of those POD problems.
>
>Best regards
>To+
>
>Test:
>1) run prove xt/author/podcorrectness.t
>it fails
>2) apply patch
>3) run again, now it's ok
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Before patch test fails. After it, it pass
>No koha-qa errors
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>---
> C4/Charset.pm          |  2 ++
> C4/SIP/ILS/Item.pm     |  2 ++
> Koha/Borrower/Files.pm | 13 ++++++++++++-
> 3 files changed, 16 insertions(+), 1 deletion(-)
>
>diff --git a/C4/Charset.pm b/C4/Charset.pm
>index acad92a..2950a71 100644
>--- a/C4/Charset.pm
>+++ b/C4/Charset.pm
>@@ -44,6 +44,8 @@ BEGIN {
>     );
> }
> 
>+=encoding UTF-8
>+
> =head1 NAME
> 
> C4::Charset - utilities for handling character set conversions.
>diff --git a/C4/SIP/ILS/Item.pm b/C4/SIP/ILS/Item.pm
>index 30586a3..7f144a8 100644
>--- a/C4/SIP/ILS/Item.pm
>+++ b/C4/SIP/ILS/Item.pm
>@@ -25,6 +25,8 @@ use Koha::Database;
> 
> our $VERSION = 3.07.00.049;
> 
>+=encoding UTF-8
>+
> =head1 EXAMPLE
> 
>  our %item_db = (
>diff --git a/Koha/Borrower/Files.pm b/Koha/Borrower/Files.pm
>index d1660bb..d816454 100644
>--- a/Koha/Borrower/Files.pm
>+++ b/Koha/Borrower/Files.pm
>@@ -36,6 +36,10 @@ BEGIN {
> 
> Koha::Borrower::Files - Module for managing borrower files
> 
>+=head1 METHODS
>+
>+=over
>+
> =cut
> 
> sub new {
>@@ -75,8 +79,11 @@ sub GetFilesInfo {
> }
> 
> =item AddFile()
>+
>     my $bf = Koha::Borrower::Files->new( borrowernumber => $borrowernumber );
>-    $bh->AddFile( name => $filename, type => $mimetype, description => $description, content => $content );
>+    $bh->AddFile( name => $filename, type => $mimetype,
>+                  description => $description, content => $content );
>+
> =cut
> 
> sub AddFile {
>@@ -100,8 +107,10 @@ sub AddFile {
> }
> 
> =item GetFile()
>+
>     my $bf = Koha::Borrower::Files->new( borrowernumber => $borrowernumber );
>     my $file = $bh->GetFile( file_id => $file_id );
>+
> =cut
> 
> sub GetFile {
>@@ -119,8 +128,10 @@ sub GetFile {
> }
> 
> =item DelFile()
>+
>     my $bf = Koha::Borrower::Files->new( borrowernumber => $borrowernumber );
>     $bh->DelFile( file_id => $file_id );
>+
> =cut
> 
> sub DelFile {
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 12462: 29125 | 29136 | 29147