Bugzilla – Attachment 29170 Details for
Bug 12143
hiding alternate address on patron self registration doesn't hide heading
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12143 - hiding alternate address on patron self registration doesn't hide heading
Bug-12143---hiding-alternate-address-on-patron-sel.patch (text/plain), 3.49 KB, created by
Marc Véron
on 2014-06-23 12:27:06 UTC
(
hide
)
Description:
Bug 12143 - hiding alternate address on patron self registration doesn't hide heading
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2014-06-23 12:27:06 UTC
Size:
3.49 KB
patch
obsolete
>From 6bad73a37d0a07af181e460f8d6b2a89975947f4 Mon Sep 17 00:00:00 2001 >From: Jacek Ablewicz <abl@biblos.pk.edu.pl> >Date: Mon, 23 Jun 2014 12:08:26 +0200 >Subject: [PATCH] Bug 12143 - hiding alternate address on patron self > registration doesn't hide heading >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch fixes the following issue: in OPAC self registration form, >even if all alternate address fields are configured as hidden, >the heading for "Alternate address" still shows. > >To test: > >1/ Confirm the issue: hide all alternate adres field names (i.e., enter >B_address|B_address2|B_city|B_state|B_zipcode|B_country|B_phone| >B_email|contactnote into PatronSelfRegistrationBorrowerUnwantedField >system prefrence). >2/ Observe that "Alternate address" section heading still shows >in patron self registration form ("your personal details" tab), >despite that all section fields are configured as hidden. >3/ Apply patch. >4/ Reload OPAC self registration form; confirm that "Alternate address" >is not displyed any longer, and the issue is now fixed. >5/ Remove some field name (e.g. B_address2) from >PatronSelfRegistrationBorrowerUnwantedField; ensure that "Alternate >address" heading does show if at least one section field is not >hidden. >6/ Test steps 1-5 should be performed/repeated in both bootstrap >and prog OPAC themes. > >Followed test plan with prog and bootstrap themes, works as expected. >Signed-off-by: Marc Véron <veron@veron.ch> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 2 +- > koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >index 4417171..7f31c96 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >@@ -450,7 +450,7 @@ > > [% UNLESS > hidden.defined('B_address') && hidden.defined('B_address2') && hidden.defined('B_city') && >- hidden.defined('B_state') && hidden.defined('B_zipcode') && hidden.defined('B_county') && >+ hidden.defined('B_state') && hidden.defined('B_zipcode') && hidden.defined('B_country') && > hidden.defined('B_phone') && hidden.defined('B_email') && hidden.defined('contactnote') > %] > <fieldset class="rows" id="memberentry_alternateaddress"> >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt >index 0e21010..1c14298 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt >@@ -458,7 +458,7 @@ > > [% UNLESS > hidden.defined('B_address') && hidden.defined('B_address2') && hidden.defined('B_city') && >- hidden.defined('B_state') && hidden.defined('B_zipcode') && hidden.defined('B_county') && >+ hidden.defined('B_state') && hidden.defined('B_zipcode') && hidden.defined('B_country') && > hidden.defined('B_phone') && hidden.defined('B_email') && hidden.defined('contactnote') > %] > <fieldset class="rows" id="memberentry_alternateaddress"> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12143
:
29164
|
29170
|
29187