Attachment 29340 Details for Bug 12438 – [PASSED QA] Bug 12438 - Bad encoding in acquisition basket

[patch] [PASSED QA] Bug 12438 - Bad encoding in acquisition basket

PASSED-QA-Bug-12438---Bad-encoding-in-acquisition-.patch (text/plain), 1.44 KB, created by Katrin Fischer on 2014-06-28 10:15:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-06-28 10:15:57 UTC

Size: 1.44 KB

patch

obsolete

>From 89498c8a99e123f75e4fd00e80ec60b35b5201bd Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Tue, 17 Jun 2014 16:38:54 +0200
>Subject: [PATCH] [PASSED QA] Bug 12438 - Bad encoding in acquisition basket
>
>We noticed a bad encoding (diacritics replaced by <?>) in acquisition basket when updating a server to Debian Wheezy.
>We found it comes from a query containing biblio.title twice.
>Maybe the mysql newer version creates this side-effect.
>
>Test plan :
>- Create an order on a record containing a diacritic in title
>- Look at the basket : cgi-bin/koha/acqui/basket.pl?basketno=x
>=> Without the patch the record title is bad encoded (with <?>)
>=> With this patch the record title is well encoded
>- Check also basket CSV export
>
>Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Good catch!
>Works as expected, passes tests and QA script.
>---
> C4/Acquisition.pm | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm
>index 2e013ac..4550dc2 100644
>--- a/C4/Acquisition.pm
>+++ b/C4/Acquisition.pm
>@@ -1052,7 +1052,6 @@ sub GetOrders {
>         SELECT biblio.*,biblioitems.*,
>                 aqorders.*,
>                 aqbudgets.*,
>-                biblio.title,
>                 aqorders_transfers.ordernumber_from AS transferred_from,
>                 aqorders_transfers.timestamp AS transferred_from_timestamp
>         FROM    aqorders
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 12438: 28911 | 29209 | 29340